website Changeset - 1c38ad017928 · Conservancy Kallithea

Changeset - 1c38ad017928

Parent rev.

Child rev.

[Not reviewed]

0 8 0

Ben Sturmfels (bsturmfels) - 2 years ago 2021-12-17 21:58:53
ben@sturm.com.au

Revert removal of "safe" template tag from blog/news headlines.

Conservancy use HTML entities in their titles.

8 files changed with 10 insertions and 10 deletions:

www/conservancy/templates/blog/entry_detail.html

www/conservancy/templates/blog/entry_partial.html

www/conservancy/templates/feeds/blog_title.html

www/conservancy/templates/feeds/news_description.html

www/conservancy/templates/feeds/news_title.html

www/conservancy/templates/news/pressrelease_detail.html

www/conservancy/templates/news/pressrelease_partial.html

www/conservancy/templates/opengraph_partial.html

0 comments (0 inline, 0 general)

www/conservancy/templates/blog/entry_detail.html

➞

Show inline comments

...		@@ -8,3 +8,3 @@

		{% block subtitle %}{{ object.headline\|striptags }} - Conservancy Blog - {% endblock %}
		{% block subtitle %}{{ object.headline\|striptags\|safe }} - Conservancy Blog - {% endblock %}

www/conservancy/templates/blog/entry_partial.html

➞

Show inline comments

@@ ... / @@ -20,3 +20,3 @@ This partial accepts these optional parameters: @@
   >{% if show|default:"body" != "body" %}<a href="{{ entry.get_absolute_url }}"
   >{% endif %}{{ entry.headline }}{% if show|default:"body" != "body" %}</a>{% endif %}</{{ htag|default:"h3" }}>
+  >{% endif %}{{ entry.headline|safe }}{% if show|default:"body" != "body" %}</a>{% endif %}</{{ htag|default:"h3" }}>

www/conservancy/templates/feeds/blog_title.html

➞

Show inline comments

		{{ obj.headline\|striptags }}
		{{ obj.headline\|striptags\|safe }}

www/conservancy/templates/feeds/news_description.html

➞

Show inline comments

 {% if obj.subhead %}<p><strong>{{ obj.subhead }}</strong></p>{% endif %}
+{% if obj.subhead %}<p><strong>{{ obj.subhead|safe }}</strong></p>{% endif %}
 {{ obj.summary|safe }}

www/conservancy/templates/feeds/news_title.html

➞

Show inline comments

		{{ obj.headline\|striptags }}
		{{ obj.headline\|striptags\|safe }}

www/conservancy/templates/news/pressrelease_detail.html

➞

Show inline comments

...		@@ -8,3 +8,3 @@

		{% block subtitle %}{{ object.headline\|striptags }} - {% endblock %}
		{% block subtitle %}{{ object.headline\|striptags\|safe }} - {% endblock %}

www/conservancy/templates/news/pressrelease_partial.html

➞

Show inline comments

@@ ... / @@ -21,3 +21,3 @@ This partial accepts these optional parameters: @@
   >{% if show|default:"body" != "body" %}<a href="{{ pressr.get_absolute_url }}"
   >{% endif %}{{ pressr.headline }}{% if show|default:"body" != "body" %}</a>{% endif %}</{{ htag|default:"h3" }}>
+  >{% endif %}{{ pressr.headline|safe }}{% if show|default:"body" != "body" %}</a>{% endif %}</{{ htag|default:"h3" }}>
@@ ... / @@ -27,3 +27,3 @@ This partial accepts these optional parameters: @@
   <h{{ htag|default:"3"|last|get_digit:1|add:1 }}
      >{{ pressr.subhead }}</h{{ htag|default:"3"|last|get_digit:1|add:1 }}>
+     >{{ pressr.subhead|safe }}</h{{ htag|default:"3"|last|get_digit:1|add:1 }}>
 {% endif %}

www/conservancy/templates/opengraph_partial.html

➞

Show inline comments

@@ ... / @@ -38,3 +38,3 @@ normally shouldn't need to: @@
 {% if title %}
 <meta property="og:title" content="{{ title|striptags }}">
+<meta property="og:title" content="{{ title|striptags|safe }}">
 {% endif %}
@@ ... / @@ -42,3 +42,3 @@ normally shouldn't need to: @@
 {% if description %}
 <meta property="og:description" content="{{ description|striptags }}">
+<meta property="og:description" content="{{ description|striptags|safe }}">
 {% endif %}

0 comments (0 inline, 0 general)