From 1c38ad01792883f8dedbc770554dbf71471889f5 2021-12-17 21:58:53
From: Ben Sturmfels <ben@sturm.com.au>
Date: 2021-12-17 21:58:53
Subject: [PATCH] Revert removal of "safe" template tag from blog/news headlines.

Conservancy use HTML entities in their titles.

---

diff --git a/www/conservancy/templates/blog/entry_detail.html b/www/conservancy/templates/blog/entry_detail.html
index 70bd722bd94c505faa81f3037f2575ca34ba42aa..87488a68ceef34ebd7b3ff0e02e9d8774f901c68 100644
--- a/www/conservancy/templates/blog/entry_detail.html
+++ b/www/conservancy/templates/blog/entry_detail.html
@@ -6,7 +6,7 @@
 {% include "opengraph_urllist_partial.html" with property='video' urls=object.get_one_video_url %}
 {% endblock %}
 
-{% block subtitle %}{{ object.headline|striptags }} - Conservancy Blog - {% endblock %}
+{% block subtitle %}{{ object.headline|striptags|safe }} - Conservancy Blog - {% endblock %}
 
 {% block content %}
 <div class="breadcrumbs">
diff --git a/www/conservancy/templates/blog/entry_partial.html b/www/conservancy/templates/blog/entry_partial.html
index 9ec8266fd1f50e4d2df80e2def478facbbbc136c..571d69f2a3eda21878d2beabc3ba495bc2a487ad 100644
--- a/www/conservancy/templates/blog/entry_partial.html
+++ b/www/conservancy/templates/blog/entry_partial.html
@@ -18,7 +18,7 @@ This partial accepts these optional parameters:
 
 <{{ htag|default:"h3" }} class="clear"
   >{% if show|default:"body" != "body" %}<a href="{{ entry.get_absolute_url }}"
-  >{% endif %}{{ entry.headline }}{% if show|default:"body" != "body" %}</a>{% endif %}</{{ htag|default:"h3" }}>
+  >{% endif %}{{ entry.headline|safe }}{% if show|default:"body" != "body" %}</a>{% endif %}</{{ htag|default:"h3" }}>
 
 {% if show != "headline" %}
 <p class="date">by <span class="author">{{ entry.author.formal_name }}</span>
diff --git a/www/conservancy/templates/feeds/blog_title.html b/www/conservancy/templates/feeds/blog_title.html
index d05ff107fb3edd2bd17ca48becfd5a705d538617..41fedac79fb4d9f8b2449b000ab5dbaa594dc417 100644
--- a/www/conservancy/templates/feeds/blog_title.html
+++ b/www/conservancy/templates/feeds/blog_title.html
@@ -1 +1 @@
-{{ obj.headline|striptags }}
+{{ obj.headline|striptags|safe }}
diff --git a/www/conservancy/templates/feeds/news_description.html b/www/conservancy/templates/feeds/news_description.html
index 69751ba964c9653e4234417407762481b442dea3..34c9a6190e8e8f934367a0f0a67f91d5aada19c1 100644
--- a/www/conservancy/templates/feeds/news_description.html
+++ b/www/conservancy/templates/feeds/news_description.html
@@ -1,3 +1,3 @@
-{% if obj.subhead %}<p><strong>{{ obj.subhead }}</strong></p>{% endif %}
+{% if obj.subhead %}<p><strong>{{ obj.subhead|safe }}</strong></p>{% endif %}
 {{ obj.summary|safe }}
 {{ obj.body|safe }}
diff --git a/www/conservancy/templates/feeds/news_title.html b/www/conservancy/templates/feeds/news_title.html
index d05ff107fb3edd2bd17ca48becfd5a705d538617..41fedac79fb4d9f8b2449b000ab5dbaa594dc417 100644
--- a/www/conservancy/templates/feeds/news_title.html
+++ b/www/conservancy/templates/feeds/news_title.html
@@ -1 +1 @@
-{{ obj.headline|striptags }}
+{{ obj.headline|striptags|safe }}
diff --git a/www/conservancy/templates/news/pressrelease_detail.html b/www/conservancy/templates/news/pressrelease_detail.html
index 8cabc8ad12de7c80d27b0ece75ee1c150877b57e..90ac7fcf9d36ba5a306d4dee2b2d40757dc67973 100644
--- a/www/conservancy/templates/news/pressrelease_detail.html
+++ b/www/conservancy/templates/news/pressrelease_detail.html
@@ -6,7 +6,7 @@
 {% include "opengraph_urllist_partial.html" with property='video' urls=object.get_one_video_url %}
 {% endblock %}
 
-{% block subtitle %}{{ object.headline|striptags }} - {% endblock %}
+{% block subtitle %}{{ object.headline|striptags|safe }} - {% endblock %}
 
 {% block content %}
 
diff --git a/www/conservancy/templates/news/pressrelease_partial.html b/www/conservancy/templates/news/pressrelease_partial.html
index 2751cb4f4e5422f71eaf64a16baba845598ec136..dc0fb6877e242df693da2cc984b0ce57803c9775 100644
--- a/www/conservancy/templates/news/pressrelease_partial.html
+++ b/www/conservancy/templates/news/pressrelease_partial.html
@@ -19,13 +19,13 @@ This partial accepts these optional parameters:
 
 <{{ htag|default:"h3" }} class="clear"
   >{% if show|default:"body" != "body" %}<a href="{{ pressr.get_absolute_url }}"
-  >{% endif %}{{ pressr.headline }}{% if show|default:"body" != "body" %}</a>{% endif %}</{{ htag|default:"h3" }}>
+  >{% endif %}{{ pressr.headline|safe }}{% if show|default:"body" != "body" %}</a>{% endif %}</{{ htag|default:"h3" }}>
 
 {% if show != "headline" %}
 {% if show != "dateline" and pressr.subhead %}
   {# This filter sequence generates the "next" hN tag from htag #}
   <h{{ htag|default:"3"|last|get_digit:1|add:1 }}
-     >{{ pressr.subhead }}</h{{ htag|default:"3"|last|get_digit:1|add:1 }}>
+     >{{ pressr.subhead|safe }}</h{{ htag|default:"3"|last|get_digit:1|add:1 }}>
 {% endif %}
 
 <p class="date">{{ pressr.pub_date|date:"F j, Y" }}</p>
diff --git a/www/conservancy/templates/opengraph_partial.html b/www/conservancy/templates/opengraph_partial.html
index 3143ca7122059240aca79285da3eecac9408dfbe..631529df4bb3d1f3dc93484703afefc3090c1072 100644
--- a/www/conservancy/templates/opengraph_partial.html
+++ b/www/conservancy/templates/opengraph_partial.html
@@ -36,9 +36,9 @@ normally shouldn't need to:
 {% endif %}
 
 {% if title %}
-<meta property="og:title" content="{{ title|striptags }}">
+<meta property="og:title" content="{{ title|striptags|safe }}">
 {% endif %}
 
 {% if description %}
-<meta property="og:description" content="{{ description|striptags }}">
+<meta property="og:description" content="{{ description|striptags|safe }}">
 {% endif %}