website Changeset - c5289f39bb3c · Conservancy Kallithea

Changeset - c5289f39bb3c

Parent rev.

Child rev.

[Not reviewed]

0 9 0

Ben Sturmfels (bsturmfels) - 2 months ago 2024-07-22 08:39:00
ben@sturm.com.au

Fix flake8 warnings

9 files changed with 35 insertions and 29 deletions:

conservancy/blog/models.py

conservancy/blog/views.py

conservancy/content/projects/policies/publish-policy.py

conservancy/feeds.py

conservancy/news/models.py

conservancy/news/views.py

conservancy/podjango/models.py

conservancy/settings/dev.py

conservancy/settings/prod.py

0 comments (0 inline, 0 general)

conservancy/blog/models.py

➞

Show inline comments

@@ ... / @@ -74,3 +74,3 @@ class Entry(models.Model, bsoup.SoupModelMixin): @@
         j = xmlrpc.client.Server('http://rpc.technorati.com/rpc/ping')
-        reply = j.weblogUpdates.ping(blog_name, blog_url)
         j.weblogUpdates.ping(blog_name, blog_url)
@@ ... / @@ -78,3 +78,3 @@ class Entry(models.Model, bsoup.SoupModelMixin): @@
         j = xmlrpc.client.Server('http://blogsearch.google.com/ping/RPC2')
-        reply = j.weblogUpdates.ping(blog_name, blog_url, post_url)
         j.weblogUpdates.ping(blog_name, blog_url, post_url)

conservancy/blog/views.py

➞

Show inline comments

@@ ... @@
 from django.shortcuts import get_object_or_404, render
 from django.views.generic import ListView
 from django.views.generic.dates import (
@@ ... / @@ -14,3 +13,3 @@ from django.views.generic.dates import ( @@
 from ..staff.models import Person
-from .models import Entry, EntryTag
 from .models import EntryTag

conservancy/content/projects/policies/publish-policy.py

➞

Show inline comments

@@ ... @@
         proc = exit_stack.enter_context(subprocess.Popen(cmd, **kwargs))
         pipes = [exit_stack.enter_context(open(
         pipes = [
             exit_stack.enter_context(open(
                 getattr(proc, name).fileno(), mode, encoding=encoding, closefd=False))
             for name in ['stdout', 'stderr']
                  if kwargs.get(name) is subprocess.PIPE]
             if kwargs.get(name) is subprocess.PIPE
+        ]
         if pipes:
@@ ... / @@ -90,2 +92,3 @@ class GitPath: @@
         attr_name = '_cached_' + orig_func.__name__
         @functools.wraps(orig_func)

conservancy/feeds.py

➞

Show inline comments

@@ ... / @@ -15,5 +15,7 @@ from .news.models import PressRelease @@
 class ConservancyFeedBase(Feed):
     def copyright_holder(self): return "Software Freedom Conservancy"
     def copyright_holder(self):
         return "Software Freedom Conservancy"
     def license_no_html(self): return "Licensed under the Creative Commons Attribution-ShareAlike 3.0 Unported License."
     def license_no_html(self):
         return "Licensed under the Creative Commons Attribution-ShareAlike 3.0 Unported License."
@@ ... / @@ -91,3 +93,4 @@ class OmnibusFeed(ConservancyFeedBase): @@
     def item_enclosure_mime_type(self): return "audio/mpeg"
     def item_enclosure_mime_type(self):
         return "audio/mpeg"
@@ ... / @@ -100,5 +103,2 @@ class OmnibusFeed(ConservancyFeedBase): @@
     def item_pubdate(self, item):
         return item.pub_date
     def item_author_name(self, item):
@@ ... / @@ -176,3 +176,4 @@ class BlogFeed(ConservancyFeedBase): @@
             for tag in tags:
                 if tag in done: continue
                 if tag in done:
                     continue
                 if firstTime:
@@ ... / @@ -194,4 +195,6 @@ class BlogFeed(ConservancyFeedBase): @@
         tags = []
         if 'author' in GET: tags = GET.getlist('author')
         if 'tag' in GET:    tags += GET.getlist('tag')
         if 'author' in GET:
             tags = GET.getlist('author')
         if 'tag' in GET:
             tags += GET.getlist('tag')
@@ ... / @@ -203,3 +206,4 @@ class BlogFeed(ConservancyFeedBase): @@
             for tag in tags:
                 if tag in done: continue
                 if tag in done:
                     continue
                 if firstTime:

conservancy/news/models.py

➞

Show inline comments

@@ ... / @@ -36,4 +36,6 @@ class PressRelease(models.Model, bsoup.SoupModelMixin): @@
     def get_absolute_url(self):
         return "/news/{}/{}/".format(self.pub_date.strftime("%Y/%b/%d").lower(),
                                   self.slug)
         return "/news/{}/{}/".format(
             self.pub_date.strftime("%Y/%b/%d").lower(),
             self.slug,
+        )
@@ ... / @@ -62,3 +64,3 @@ class PressRelease(models.Model, bsoup.SoupModelMixin): @@
         j = xmlrpc.client.Server('http://rpc.technorati.com/rpc/ping')
-        reply = j.weblogUpdates.ping(blog_name, blog_url)
         j.weblogUpdates.ping(blog_name, blog_url)
@@ ... / @@ -66,3 +68,3 @@ class PressRelease(models.Model, bsoup.SoupModelMixin): @@
         j = xmlrpc.client.Server('http://blogsearch.google.com/ping/RPC2')
-        reply = j.weblogUpdates.ping(blog_name, blog_url, post_url)
         j.weblogUpdates.ping(blog_name, blog_url, post_url)

conservancy/news/views.py

➞

Show inline comments

@@ ... / @@ -3,3 +3,2 @@ from datetime import datetime @@
 from django.core.paginator import EmptyPage, PageNotAnInteger, Paginator
 from django.http import HttpResponse
 from django.shortcuts import render
@@ ... / @@ -13,4 +12,3 @@ from django.views.generic.dates import ( @@
 from ..events.models import Event
 from .models import ExternalArticle, PressRelease
 from .models import PressRelease
@@ ... / @@ -29,4 +27,5 @@ def listing(request, *args, **kwargs): @@
 #    if (not kwargs.has_key('allow_future')) or not kwargs['allow_future']:
     news_queryset = news_queryset.filter(**{'%s__lte' % kwargs['date_field']:
                           datetime.now()})
     news_queryset = news_queryset.filter(
         **{'%s__lte' % kwargs['date_field']: datetime.now()}
+    )

conservancy/podjango/models.py

➞

Show inline comments

...		@@ -21,3 +21,2 @@ from datetime import datetime, timedelta
		from django.db import models
		from django.urls import reverse

conservancy/settings/dev.py

➞

Show inline comments

		from .base import *
		from .base import * # NOQA

conservancy/settings/prod.py

➞

Show inline comments

@@ ... / @@ -4,3 +4,3 @@ from django.core.exceptions import ImproperlyConfigured @@
 from .base import *
+from .base import *  # NOQA
@@ ... / @@ -27,3 +27,3 @@ DATABASES = { @@
 # to Django (can't use the Apache config).
 with open(BASE_DIR.parent / 'secrets.json') as f:
+with open(BASE_DIR.parent / 'secrets.json') as f:  # NOQA
     secrets = json.load(f)

0 comments (0 inline, 0 general)