Changeset - 75e3ab4d35f0
[Not reviewed]
0 8 0
Ben Sturmfels (bsturmfels) - 3 months ago 2024-02-23 04:02:04
ben@sturm.com.au
podjango: Fix linting warnings
8 files changed with 36 insertions and 16 deletions:
0 comments (0 inline, 0 general)
TODO.md
Show inline comments
...
 
@@ -2,2 +2,4 @@
 

	
 
* remove `ForceCanonicalHostnameMiddleware` by ensuring canonical redirect and HTTPS redirect is done by Apache
 
* serve a 400 in Apache for a hostname we don't explicitly support
 
* use `<detail>` elements for supporter page hidden sections, rather than complex jQuery - or consider Alpine.js
conservancy/podjango/admin.py
Show inline comments
...
 
@@ -26,4 +26,6 @@ class CastTagAdmin(admin.ModelAdmin):
 

	
 

	
 
admin.site.register(CastTag, CastTagAdmin)
 

	
 

	
 
class CastAdmin(admin.ModelAdmin):
conservancy/podjango/feeds.py
Show inline comments
...
 
@@ -20,6 +20,3 @@
 
from datetime import datetime
 
import itertools
 
import operator
 

	
 
from django.conf import settings
 
from django.contrib.sites.shortcuts import get_current_site
...
 
@@ -57,4 +54,6 @@ class CastFeedBase(Feed):
 

	
 

	
 
def for_podcast_feed_extra_kwargs(self, obj):
 
    return { 'managingEditorNames' : 'Bradley and Karen',
 
    return {
 
        'managingEditorNames': 'Bradley and Karen',
 
        'rssImage': {'url': 'http://faif.us/img/cast/faif_144x144.jpg',
...
 
@@ -75,9 +74,14 @@ def for_podcast_feed_extra_kwargs(self, obj):
 
        'copyrightHolder': self.copyright_holder(),
 
             'copyrightLicense' : self.license_no_html() }
 
        'copyrightLicense': self.license_no_html(),
 
    }
 

	
 

	
 
def for_podcast_item_extra_kwargs(self, item):
 
    return { 'duration' : item.duration,
 
    return {
 
        'duration': item.duration,
 
        'year': item.date_created.year,
 
        'dcCreator': 'oggcast@faif.us (Bradley and Karen)',
 
             'intheitembkuhn' : item.__dict__.__str__()}
 
        'intheitembkuhn': item.__dict__.__str__(),
 
    }
 

	
 

	
...
 
@@ -141,2 +145,3 @@ def podcast_helper_add_root_elements(self, handler):
 

	
 

	
 
def podcast_helper_add_item_elements(self, handler, item):
...
 
@@ -238,2 +243,3 @@ class Mp3CastFeed(CastFeed):
 

	
 

	
 
class OggCastFeed(CastFeed):
...
 
@@ -245,2 +251,3 @@ class OggCastFeed(CastFeed):
 

	
 

	
 
feed_dict = {
...
 
@@ -254,2 +261,3 @@ for k, v in feed_dict.items():
 

	
 

	
 
def view(request):
conservancy/podjango/frontpage.py
Show inline comments
...
 
@@ -19,3 +19,3 @@
 

	
 
from datetime import datetime, timedelta
 
from datetime import datetime
 

	
conservancy/podjango/models.py
Show inline comments
...
 
@@ -55,5 +55,7 @@ class Cast(models.Model):
 
    tags = models.ManyToManyField(CastTag, blank=True)
 
    ogg_path = models.CharField(max_length=300, blank=True,
 
    ogg_path = models.CharField(
 
        max_length=300, blank=True,
 
        help_text="Local filename of the Ogg file, relative to webroot.  File should be uploaded into the static media area for casts.")
 
    mp3_path = models.CharField(max_length=300, blank=True,
 
    mp3_path = models.CharField(
 
        max_length=300, blank=True,
 
        help_text="Local filename of the mp3 file, relative to webroot.  File should be uploaded into the static media area for casts.")
conservancy/podjango/templatetags/date_within.py
Show inline comments
...
 
@@ -6,2 +6,3 @@ register = template.Library()
 

	
 

	
 
@register.filter
conservancy/podjango/urls.py
Show inline comments
...
 
@@ -19,6 +19,6 @@
 

	
 
import datetime
 

	
 
from django.conf import settings
 
from django.conf.urls import include, url
 
from django.contrib import admin
 
from django.contrib.syndication.views import Feed
 
from django.conf.urls import url
 
from django.views.generic.dates import (
...
 
@@ -31,3 +31,3 @@ from django.views.generic.dates import (
 
from . import frontpage
 
from .feeds import Mp3CastFeed, OggCastFeed, feed_dict, view
 
from .feeds import Mp3CastFeed, OggCastFeed, view
 
from .models import Cast, CastTag
...
 
@@ -62,2 +62,3 @@ if settings.DEBUG:
 

	
 

	
 
def all_tags_by_use_amount():
...
 
@@ -87,2 +88,3 @@ def all_tags_by_use_amount():
 

	
 

	
 
# The functions are passed to the context uncalled so they will be
conservancy/podjango/views.py
Show inline comments
...
 
@@ -23,5 +23,4 @@ from operator import or_
 
from django.shortcuts import get_object_or_404, render
 
from django.views.generic.list import ListView
 

	
 
from .models import Cast, CastTag
 
from .models import CastTag
 

	
...
 
@@ -33,2 +32,3 @@ def OR_filter(field_name, objs):
 

	
 

	
 
def last_name(person):
...
 
@@ -36,2 +36,3 @@ def last_name(person):
 

	
 

	
 
def custom_index(request, queryset, *args, **kwargs):
...
 
@@ -77,2 +78,3 @@ def custom_index(request, queryset, *args, **kwargs):
 

	
 

	
 
def query(request):
...
 
@@ -102,2 +104,3 @@ def query(request):
 

	
 

	
 
def relative_redirect(request, path):
0 comments (0 inline, 0 general)