symposion_app Changeset - b9b50c68466b

Changeset - b9b50c68466b

Parent rev.

Child rev.

[Not reviewed]

0 2 0

Christopher Neugebauer - 8 years ago 2016-05-01 04:56:51
chrisjrn@gmail.com

Bug fixes and query optimisations in flag.py and discount.py

2 files changed with 5 insertions and 1 deletions:

registrasion/controllers/discount.py

registrasion/controllers/flag.py

0 comments (0 inline, 0 general)

registrasion/controllers/discount.py

➞

Show inline comments

@@ ... / @@ -117,12 +117,14 @@ class DiscountController(object): @@
         product_clauses = conditions.DiscountForProduct.objects.all()
         product_clauses = product_clauses.select_related(
             "discount",
             "product",
             "product__category",
+        )
         category_clauses = conditions.DiscountForCategory.objects.all()
         category_clauses = category_clauses.select_related(
             "category",
             "discount",
+        )
         valid_discounts = conditions.DiscountBase.objects.all()

registrasion/controllers/flag.py

➞

Show inline comments

@@ ... / @@ -85,6 +85,8 @@ class FlagController(object): @@
             # from the categories covered by this condition
             ids = [product.id for product in products]
             # TODO: This is re-evaluated a lot.
             all_products = inventory.Product.objects.filter(id__in=ids)
             cond = (
                 Q(flagbase_set=condition) |
@@ ... / @@ -181,7 +183,7 @@ class FlagController(object): @@
             flags = ctrl.pre_filter(flags, user)
             all_subsets.append(flags)
         return itertools.chain(*all_subsets)
+        return list(itertools.chain(*all_subsets))
 ConditionAndRemainder = namedtuple(

0 comments (0 inline, 0 general)