NPO-Accounting/oxrlib Changeset - 9d4723824592

Changeset - 9d4723824592

Parent rev.

Child rev.

[Not reviewed]

0 3 0

Brett Smith - 7 years ago 2017-05-16 16:26:32
brettcsmith@brettcsmith.org

rate: Add Rate.convert method.

3 files changed with 19 insertions and 2 deletions:

oxrlib/rate.py

tests/historical1.json

tests/test_Rate.py

0 comments (0 inline, 0 general)

oxrlib/rate.py

➞

Show inline comments

 import datetime
 import decimal
 import functools
 import json
@@ ... / @@ -35,4 +36,8 @@ class Rate: @@
         return datetime.datetime.fromtimestamp(value)
     @classmethod
     def serialize_rates(cls, rates):
         return {code: float(rates[code]) for code in rates}
     @classmethod
     def serialize_timestamp(cls, value):
@@ ... / @@ -41,7 +46,10 @@ class Rate: @@
     @classmethod
     def from_json_file(cls, json_file):
         response = json.load(json_file)
+        response = json.load(json_file, parse_float=decimal.Decimal)
         return cls(**response)
     def convert(self, amount, from_currency, to_currency):
         return amount * self.rates[to_currency] / self.rates[from_currency]
     def serialize(self):
         return dict(self.walk_fields(functools.partial(getattr, self), 'serialize'))

tests/historical1.json

➞

Show inline comments

@@ ... / @@ -7,5 +7,6 @@ @@
         "AED": 3.67246,
         "ALL": 144.529793,
         "ANG": 1.79
         "ANG": 1.79,
         "USD": 1
+    }
+}

tests/test_Rate.py

➞

Show inline comments

 import datetime
 import decimal
 import io
 import json
@@ ... / @@ -8,4 +9,7 @@ import oxrlib.rate @@
 import pytest
 HIST1_AED_RATE = decimal.Decimal('3.67246')
 HIST1_ALL_RATE = decimal.Decimal('144.529793')
 @pytest.fixture
 def historical1_rate():
@@ ... / @@ -22,2 +26,6 @@ def test_serialize(historical1_rate): @@
     assert expected == historical1_rate.serialize()
 def test_convert(historical1_rate):
     assert historical1_rate.convert(2, 'USD', 'ALL') == (2 * HIST1_ALL_RATE)
     assert historical1_rate.convert(10, 'AED', 'USD') == (10 / HIST1_AED_RATE)
     assert historical1_rate.convert(1, 'AED', 'ALL') == (HIST1_ALL_RATE / HIST1_AED_RATE)

0 comments (0 inline, 0 general)