NPO-Accounting/npo-ledger-cli Pull Request #16

Pull request #16 from npo-ledger-cli-fork-georglink#typos

Title: add commas and double quote (Closed)

Description:

This pull request makes minor grammatical fixes to the npo-ledger-cli tutorial

Voting Result:

Closed, Under review

Origin:

npo-ledger-cli-fork-georglink#typos (776012db6223)

Target:

NPO-Accounting/npo-ledger-cli#master

Pull changes:

git pull https://k.sfconservancy.org/npo-ledger-cli-fork-georglink typos

Created on:

2019-03-26 15:39:04

Owner:

Georg Link (GeorgLink)
linkgeorg@gmail.com

Next iteration:

Git pull requests don't support iterating yet.

Reviewers

Potential Reviewers

Click to add the repository owner as reviewer:

Bradley Kuhn

Pull Request Content

3 comments (0 inline, 3 general)

Showing 2 commits

2		GeorgLink	776012db6223	5 years ago		oxford comma typos
1		GeorgLink	d0277344ad02	5 years ago		fix grammar

Common ancestor: d376f17a0e86

1 file changed with 3 insertions and 4 deletions:

npo-ledger-cli-tutorial.md

➞

Show inline comments

@@ ... @@
 * `RBI`, which refers to "related business income".
 * `UBTI`, which refers to "unrelated business taxable income.
+* `UBTI`, which refers to "unrelated business taxable income".
 Not that donor-advised funds and government grants don't currently have their
 own `IncomeType`.  It's possible this might be necessary; the authors aren't
@@ ... @@
 Each `Expenses:` account entry must be tagged with the following tags:
 * One of: [`Invoice:`](#invoice-tag) [`Receipt:`](#receipt-tag), or
+* One of: [`Invoice:`](#invoice-tag), [`Receipt:`](#receipt-tag), or
   [`Statement`](#statement-tag).  (The only exception to this rule: an entry
   does not need an `Invoice:`, `Receipt`, nor a `Statement` tag if the
   [payee was never charged](#never-charged-payee).)
@@ ... / @@ -463,7 +463,7 @@ Each `Income:` account must have the following tags: @@
 * One of: [`Invoice:`](#invoice-tag),
   [`PurchaseOrder:`](#purchase-order-tag),
   [`Statement:`](#statement-tag) or
+  [`Statement:`](#statement-tag), or
   [`Contract`](#contract-tag).  Exceptions to this requirement are as follows:
      + the income generated from the transaction is less than $800, or
      + the `IncomeType` is `RBI` and the income is for a defined, public
@@ ... / @@ -573,4 +573,3 @@ document has been separated from the repository, a @@
 [copy of GPL can be found on FSF's website](http://www.gnu.org/licenses/gpl.txt)
 and a
 [copy of CC-By-SA-USA-3.0 can be found on Creative Commons' website](http://creativecommons.org/licenses/by-sa/3.0/us/legalcode).

Georg Link (GeorgLink) 5 years ago comment on pull request "add commas and double quote" ¶

Status change: Under review

Martin Michlmayr (tbm) 5 years ago comment on pull request "add commas and double quote" ¶

I don't know how to close pull requests but I've merged that. Thanks

Georg Link (GeorgLink) 5 years ago comment on pull request "add commas and double quote" ¶

Status change: Approved

Closing.
Thanks @tbm. I have the option to "vote" on the pull request status. (My first time using kallithea, still learning its interface).

3 comments (0 inline, 3 general)