diff --git a/tests/test_meta_invoice.py b/tests/test_meta_invoice.py index 5586e75b4f78d521fb2d715ab5fdb2300664a75c..fcaa6ce8845844e2c4051f5dff0fb8f0ca5f0e0b 100644 --- a/tests/test_meta_invoice.py +++ b/tests/test_meta_invoice.py @@ -20,18 +20,6 @@ from . import testutil from conservancy_beancount.plugin import meta_invoice -VALID_VALUES = { - 'Invoices/304321.pdf', - 'rt:123/456', - 'rt://ticket/234', -} - -INVALID_VALUES = { - '', - ' ', - ' ', -} - REQUIRED_ACCOUNTS = { 'Accrued:AccountsPayable', 'Accrued:AccountsReceivable', @@ -55,7 +43,7 @@ def hook(): @pytest.mark.parametrize('acct1,acct2,value', testutil.combine_values( REQUIRED_ACCOUNTS, NON_REQUIRED_ACCOUNTS, - VALID_VALUES, + testutil.LINK_METADATA_STRINGS, )) def test_valid_values_on_postings(hook, acct1, acct2, value): txn = testutil.Transaction(postings=[ @@ -67,7 +55,7 @@ def test_valid_values_on_postings(hook, acct1, acct2, value): @pytest.mark.parametrize('acct1,acct2,value', testutil.combine_values( REQUIRED_ACCOUNTS, NON_REQUIRED_ACCOUNTS, - INVALID_VALUES, + testutil.NON_LINK_METADATA_STRINGS, )) def test_invalid_values_on_postings(hook, acct1, acct2, value): txn = testutil.Transaction(postings=[ @@ -98,7 +86,7 @@ def test_bad_type_values_on_postings(hook, acct1, acct2, value): @pytest.mark.parametrize('acct1,acct2,value', testutil.combine_values( REQUIRED_ACCOUNTS, NON_REQUIRED_ACCOUNTS, - VALID_VALUES, + testutil.LINK_METADATA_STRINGS, )) def test_valid_values_on_transaction(hook, acct1, acct2, value): txn = testutil.Transaction(**{TEST_KEY: value}, postings=[ @@ -110,7 +98,7 @@ def test_valid_values_on_transaction(hook, acct1, acct2, value): @pytest.mark.parametrize('acct1,acct2,value', testutil.combine_values( REQUIRED_ACCOUNTS, NON_REQUIRED_ACCOUNTS, - INVALID_VALUES, + testutil.NON_LINK_METADATA_STRINGS, )) def test_invalid_values_on_transaction(hook, acct1, acct2, value): txn = testutil.Transaction(**{TEST_KEY: value}, postings=[