diff --git a/tests/test_meta_expense_allocation.py b/tests/test_meta_expense_allocation.py index 5995cdbef8fe312ee68378b9302f363779d304d8..623dc9668a6d31817a90fc88bf8c2d2949e2dad4 100644 --- a/tests/test_meta_expense_allocation.py +++ b/tests/test_meta_expense_allocation.py @@ -46,7 +46,7 @@ def test_valid_values_on_postings(src_value, set_value): checker = meta_expense_allocation.MetaExpenseAllocation() errors = list(checker.run(txn)) assert not errors - assert txn.postings[-1].meta.get(TEST_KEY) == set_value + testutil.check_post_meta(txn, None, {TEST_KEY: set_value}) @pytest.mark.parametrize('src_value', INVALID_VALUES) def test_invalid_values_on_postings(src_value): @@ -57,6 +57,7 @@ def test_invalid_values_on_postings(src_value): checker = meta_expense_allocation.MetaExpenseAllocation() errors = list(checker.run(txn)) assert errors + testutil.check_post_meta(txn, None, {TEST_KEY: src_value}) @pytest.mark.parametrize('src_value,set_value', VALID_VALUES.items()) def test_valid_values_on_transactions(src_value, set_value): @@ -67,7 +68,7 @@ def test_valid_values_on_transactions(src_value, set_value): checker = meta_expense_allocation.MetaExpenseAllocation() errors = list(checker.run(txn)) assert not errors - assert txn.postings[-1].meta.get(TEST_KEY) == set_value + testutil.check_post_meta(txn, None, {TEST_KEY: set_value}) @pytest.mark.parametrize('src_value', INVALID_VALUES) def test_invalid_values_on_transactions(src_value): @@ -78,6 +79,7 @@ def test_invalid_values_on_transactions(src_value): checker = meta_expense_allocation.MetaExpenseAllocation() errors = list(checker.run(txn)) assert errors + testutil.check_post_meta(txn, None, None) @pytest.mark.parametrize('account', [ 'Accrued:AccountsReceivable', @@ -87,13 +89,15 @@ def test_invalid_values_on_transactions(src_value): 'UnearnedIncome:Donations', ]) def test_non_expense_accounts_skipped(account): + meta = {TEST_KEY: 'program'} txn = testutil.Transaction(postings=[ (account, -25), - ('Expenses:General', 25, {TEST_KEY: 'program'}), + ('Expenses:General', 25, meta.copy()), ]) checker = meta_expense_allocation.MetaExpenseAllocation() errors = list(checker.run(txn)) assert not errors + testutil.check_post_meta(txn, None, meta) @pytest.mark.parametrize('account,set_value', [ ('Expenses:Services:Accounting', 'administration'), @@ -110,14 +114,14 @@ def test_default_values(account, set_value): checker = meta_expense_allocation.MetaExpenseAllocation() errors = list(checker.run(txn)) assert not errors - assert txn.postings[-1].meta[TEST_KEY] == set_value + testutil.check_post_meta(txn, None, {TEST_KEY: set_value}) @pytest.mark.parametrize('date,set_value', [ - (testutil.EXTREME_FUTURE_DATE, False), - (testutil.FUTURE_DATE, True), - (testutil.FY_START_DATE, True), - (testutil.FY_MID_DATE, True), - (testutil.PAST_DATE, False), + (testutil.EXTREME_FUTURE_DATE, None), + (testutil.FUTURE_DATE, 'program'), + (testutil.FY_START_DATE, 'program'), + (testutil.FY_MID_DATE, 'program'), + (testutil.PAST_DATE, None), ]) def test_default_value_set_in_date_range(date, set_value): txn = testutil.Transaction(date=date, postings=[ @@ -127,5 +131,5 @@ def test_default_value_set_in_date_range(date, set_value): checker = meta_expense_allocation.MetaExpenseAllocation() errors = list(checker.run(txn)) assert not errors - got_value = (txn.postings[-1].meta or {}).get(TEST_KEY) - assert bool(got_value) == bool(set_value) + expect_meta = None if set_value is None else {TEST_KEY: set_value} + testutil.check_post_meta(txn, None, expect_meta)