Changeset - da056917bfa4
Parent rev.
Child rev.
[Not reviewed]
0 3 0
Brett Smith - 4 years ago 2020-09-05 18:59:13
brettcsmith@brettcsmith.org
meta_repo_links: Check all non-RT links. RT#12517

This is less "future-proof," but the thing is, it's premature to try
to anticipate what other link formats will be in the future. See
discussion in comments.
3 files changed with 22 insertions and 4 deletions:
conservancy_beancount/plugin/meta_repo_links.py
15
3
setup.py
1
1
tests/test_meta_repo_links.py
6
0 comments (0 inline, 0 general)
conservancy_beancount/plugin/meta_repo_links.py
➞
Show inline comments
...
 
@@ -22,2 +22,3 @@ from .. import data
 
from .. import errors as errormod
 
from .. import rtutil
 
from ..beancount_types import (
...
 
@@ -37,3 +38,2 @@ class MetaRepoLinks(core.TransactionHook):
 
    LINK_METADATA = data.LINK_METADATA.difference('rt-id')
 
    PATH_PUNCT_RE = re.compile(r'[:/]')
 
    SKIP_FLAGS = '!'
...
 
@@ -59,4 +59,16 @@ class MetaRepoLinks(core.TransactionHook):
 
                for link in links:
 
                    match = self.PATH_PUNCT_RE.search(link)
 
                    if match and match.group(0) == ':':
 
                    # FUTURE DEVELOPMENT NOTE: As of this writing we have two
 
                    # link checkers. Right now the division of reporting
 
                    # responsibility is: MetaRTLinks reports problems with any
 
                    # link that starts with `rt:`, while this checker reports
 
                    # problems with anything else.
 
                    # If we add more link checkers in the future, we might need
 
                    # to give more thought about which checker is responsible
 
                    # for flagging links in "unknown formats." But today, I
 
                    # can't write better code that anticipates that need
 
                    # without having any idea of what future link formats will
 
                    # look like. Today, asking the RT parser "can you handle
 
                    # this?" is the safest way to make sure all bad links get
 
                    # reported.
 
                    if rtutil.RT.parse(link) is not None:
 
                        pass
setup.py
➞
Show inline comments
...
 
@@ -7,3 +7,3 @@ setup(
 
    description="Plugin, library, and reports for reading Conservancy's books",
 
    version='1.9.6',
 
    version='1.9.7',
 
    author='Software Freedom Conservancy',
tests/test_meta_repo_links.py
➞
Show inline comments
...
 
@@ -47,2 +47,8 @@ BAD_LINKS = [Path(s) for s in [
 
    'NonexistentDirectory/NonexistentFile2.txt',
 
    'egproto:',
 
    'egproto:123',
 
    'egproto:123/456',
 
    'egproto:foo'
 
    'egproto:/foo/bar',
 
    ';egproto::',
 
]]
0 comments (0 inline, 0 general)
Server instance: kapok.sfconservancy.org-29260 This site is powered by Kallithea 0.6.3, which is © 2010–2020 by various authors & licensed under GPLv3. – Support – Privacy Policy