NPO-Accounting/conservancy_beancount Changeset - d3415a8721c3

Changeset - d3415a8721c3

Parent rev.

Child rev.

[Not reviewed]

0 1 0

Brett Smith - 4 years ago 2020-04-27 20:44:06
brettcsmith@brettcsmith.org

data: Type declare that Posting.meta is a PostingMeta.

This is necessary for users to call PostingMeta properties like date
as intended.

1 file changed with 1 insertions and 1 deletions:

conservancy_beancount/data.py

0 comments (0 inline, 0 general)

conservancy_beancount/data.py

➞

Show inline comments

@@ ... / @@ -263,25 +263,25 @@ class Posting(BasePosting): @@
     * The `meta` field is a PostingMeta object
     """
     __slots__ = ()
     account: Account
     units: Amount
     # mypy correctly complains that our MutableMapping is not compatible
     # with Beancount's meta type declaration of Optional[Dict]. IMO
     # Beancount's type declaration is a smidge too specific: I think its type
     # declaration should also use MutableMapping, because it would be very
     # unusual for code to specifically require a Dict over that.
     # If it did, this declaration would pass without issue.
-    meta: Metadata  # type:ignore[assignment]
+    meta: PostingMeta  # type:ignore[assignment]
     @classmethod
     def from_beancount(cls,
                        txn: Transaction,
                        index: int,
                        post: Optional[BasePosting]=None,
     ) -> 'Posting':
         if post is None:
             post = txn.postings[index]
         return cls(
             Account(post.account),
             *post[1:5],

0 comments (0 inline, 0 general)