NPO-Accounting/conservancy_beancount Changeset - a4bba120eb37

Changeset - a4bba120eb37

Parent rev.

Child rev.

[Not reviewed]

0 1 0

Ben Sturmfels (bsturmfels) - 16 months ago 2023-02-11 03:53:30
ben@sturm.com.au

reconlicer: Move match thresholds to top of module

1 file changed with 9 insertions and 6 deletions:

conservancy_beancount/reconcile/statement_reconciler.py

0 comments (0 inline, 0 general)

conservancy_beancount/reconcile/statement_reconciler.py

➞

Show inline comments

@@ ... / @@ -79,6 +79,11 @@ Other related problems we're not dealing with here: @@
  - transactions are entered manually and reconciled after the fact, but
    importing from statements may be useful in some cases
 Current issue:
  - entry_point seems to swallow errors, meaning you get a fairly unhelpful
    message if there's an unhandled error
 Future possibilities:
  - allow the reconciler to respect manually-applied metadata - not clear how
@@ ... / @@ -90,10 +95,6 @@ Future possibilities: @@
    reconciles and summarises the unreconciled transactions
 """
 # TODO:
 #  - entry_point seems to swallow errors
 #  - extract the magic numbers
 import argparse
 import collections
 import copy
@@ ... / @@ -150,6 +151,8 @@ JUNK_WORDS = [ @@
+]
 JUNK_WORDS_RES = [re.compile(word, re.IGNORECASE) for word in JUNK_WORDS]
 ZERO_RE = re.compile('^0+')
 FULL_MATCH_THRESHOLD = 0.8
 PARTIAL_MATCH_THRESHOLD = 0.4
 def remove_duplicate_words(text: str) -> str:
@@ ... @@
     else:
         check_score = 0.0
         payee_score = payee_match(r1['payee'], r2['payee'])
-        if payee_score > 0.8:
+        if payee_score > FULL_MATCH_THRESHOLD:
             payee_message = ''
-        elif payee_score > 0.4:
+        elif payee_score > PARTIAL_MATCH_THRESHOLD:
             payee_message = 'partial payee match'
         else:
             payee_message = 'payee mismatch'

0 comments (0 inline, 0 general)