NPO-Accounting/conservancy_beancount Changeset - 9c335175835c

Changeset - 9c335175835c

Parent rev.

Child rev.

[Not reviewed]

0 3 0

Brett Smith - 4 years ago 2020-06-11 14:44:05
brettcsmith@brettcsmith.org

data: Add Metadata.first_link() method.

3 files changed with 45 insertions and 5 deletions:

conservancy_beancount/data.py

conservancy_beancount/reports/accrual.py

tests/test_data_metadata.py

0 comments (0 inline, 0 general)

conservancy_beancount/data.py

➞

Show inline comments

@@ ... / @@ -244,6 +244,18 @@ class Metadata(MutableMapping[MetaKey, MetaValue]): @@
                 key, type(value).__name__,
             ))
     @overload
     def first_link(self, key: MetaKey, default: None=None) -> Optional[str]: ...
     @overload
     def first_link(self, key: MetaKey, default: str) -> str: ...
     def first_link(self, key: MetaKey, default: Optional[str]=None) -> Optional[str]:
         try:
             return self.get_links(key)[0]
         except (IndexError, TypeError):
             return default
 class PostingMeta(Metadata):
     """Combined access to posting metadata with its parent transaction metadata

conservancy_beancount/reports/accrual.py

➞

Show inline comments

@@ ... / @@ -220,11 +220,7 @@ class AccrualPostings(core.RelatedPostings): @@
                         seen.add(entity)
     def first_links(self, key: MetaKey, default: Optional[str]=None) -> Iterator[Optional[str]]:
         for post in self:
             try:
                 yield post.meta.get_links(key)[0]
             except (IndexError, TypeError):
                 yield default
         return (post.meta.first_link(key, default) for post in self)
     def make_consistent(self) -> Iterator[Tuple[MetaValue, 'AccrualPostings']]:
         account_ok = isinstance(self.account, str)

tests/test_data_metadata.py

➞

Show inline comments

@@ ... / @@ -57,3 +57,35 @@ def test_get_links_bad_type(value): @@
     meta = data.Metadata({'key': value})
     with pytest.raises(TypeError):
         meta.get_links('key')
 def test_first_link_from_txn(simple_txn):
     meta = data.PostingMeta(simple_txn, 0)
     assert meta.first_link('note') == 'txn'
 def test_first_link_from_post_override(simple_txn):
     meta = data.PostingMeta(simple_txn, 1)
     assert meta.first_link('note') == 'donation'
 def test_first_link_is_only_link(simple_txn):
     meta = data.PostingMeta(simple_txn, 1)
     assert meta.first_link('extra') == 'Extra'
 def test_first_link_nonexistent_metadata(simple_txn):
     meta = data.PostingMeta(simple_txn, 1)
     assert meta.first_link('Nonexistent') is None
 def test_first_link_nonexistent_default(simple_txn):
     meta = data.PostingMeta(simple_txn, 1)
     assert meta.first_link('Nonexistent', 'missing') == 'missing'
 @pytest.mark.parametrize('meta_value', testutil.NON_STRING_METADATA_VALUES)
 def test_first_link_bad_type_metadata(simple_txn, meta_value):
     simple_txn.meta['badmeta'] = meta_value
     meta = data.PostingMeta(simple_txn, 1)
     assert meta.first_link('badmeta') is None
 @pytest.mark.parametrize('meta_value', testutil.NON_STRING_METADATA_VALUES)
 def test_first_link_bad_type_default(simple_txn, meta_value):
     simple_txn.meta['badmeta'] = meta_value
     meta = data.PostingMeta(simple_txn, 1)
     assert meta.first_link('badmeta', '_') == '_'

0 comments (0 inline, 0 general)