NPO-Accounting/conservancy_beancount Changeset - 9699f4e52766

Changeset - 9699f4e52766

Parent rev.

Child rev.

[Not reviewed]

0 2 0

Brett Smith - 4 years ago 2020-06-25 17:52:37
brettcsmith@brettcsmith.org

income_type: Set a default for TrademarkSales. RT#8869.

2 files changed with 2 insertions and 0 deletions:

conservancy_beancount/plugin/meta_income_type.py

tests/test_meta_income_type.py

0 comments (0 inline, 0 general)

conservancy_beancount/plugin/meta_income_type.py

➞

Show inline comments

@@ ... / @@ -11,42 +11,43 @@ @@
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU Affero General Public License for more details.
+#
 # You should have received a copy of the GNU Affero General Public License
 # along with this program.  If not, see <https://www.gnu.org/licenses/>.
 from . import core
 from .. import data
 from .. import errors as errormod
 from ..beancount_types import (
     MetaValueEnum,
     Transaction,
+)
 class MetaIncomeType(core._NormalizePostingMetadataHook):
     VALUES_ENUM = core.MetadataEnum('income-type', {
         'Donations',
         'Payable-Derecognition',
         'RBI',
         'UBTI',
     })
     DEFAULT_VALUES = {
         'Income:Conferences:Registrations': 'RBI',
         'Income:Conferences:Sponsorship': 'RBI',
         'Income:Donations': 'Donations',
         'Income:Honoraria': 'RBI',
         'Income:Interest': 'RBI',
         'Income:Interest:Dividend': 'RBI',
         'Income:Royalties': 'RBI',
         'Income:Sales': 'RBI',
         'Income:SoftwareDevelopment': 'RBI',
         'Income:TrademarkLicensing': 'RBI',
         'Income:TrademarkSales': 'RBI',
+    }
     def _run_on_post(self, txn: Transaction, post: data.Posting) -> bool:
         return post.account.is_under('Income') is not None
     def _default_value(self, txn: Transaction, post: data.Posting) -> MetaValueEnum:
         try:
             return self.DEFAULT_VALUES[post.account]
         except KeyError:
             raise errormod.InvalidMetadataError(txn, self.METADATA_KEY, None, post) from None

tests/test_meta_income_type.py

➞

Show inline comments

@@ ... / @@ -82,64 +82,65 @@ def test_invalid_values_on_transactions(hook, src_value): @@
     assert errors
     testutil.check_post_meta(txn, None, None)
 @pytest.mark.parametrize('account', [
     'Assets:Cash',
     'Assets:Receivable:Accounts',
     'Equity:OpeningBalance',
     'Expenses:Other',
     'Liabilities:CreditCard',
     'Liabilities:Payable:Vacation',
 ])
 def test_non_income_accounts_skipped(hook, account):
     meta = {TEST_KEY: 'RBI'}
     txn = testutil.Transaction(postings=[
         (account, 25),
         ('Income:Other', -25, meta.copy()),
     ])
     errors = list(hook.run(txn))
     assert not errors
     testutil.check_post_meta(txn, None, meta)
 @pytest.mark.parametrize('account,set_value', [
     ('Income:Conferences:Registrations', 'RBI'),
     ('Income:Conferences:Sponsorship', 'RBI'),
     ('Income:Donations', 'Donations'),
     ('Income:Honoraria', 'RBI'),
     ('Income:Interest', 'RBI'),
     ('Income:Interest:Dividend', 'RBI'),
     ('Income:Royalties', 'RBI'),
     ('Income:Sales', 'RBI'),
     ('Income:SoftwareDevelopment', 'RBI'),
     ('Income:TrademarkLicensing', 'RBI'),
     ('Income:TrademarkSales', 'RBI'),
 ])
 def test_default_values(hook, account, set_value):
     txn = testutil.Transaction(postings=[
         ('Assets:Cash', 25),
         (account, -25),
     ])
     errors = list(hook.run(txn))
     assert not errors
     testutil.check_post_meta(txn, None, {TEST_KEY: set_value})
 @pytest.mark.parametrize('account', [
     'Income:Other',
 ])
 def test_no_default_value(hook, account):
     txn = testutil.Transaction(postings=[
         ('Assets:Cash', 25),
         (account, -25),
     ])
     errors = list(hook.run(txn))
     assert errors
     testutil.check_post_meta(txn, None, None)
 @pytest.mark.parametrize('date,set_value', [
     (testutil.EXTREME_FUTURE_DATE, None),
     (testutil.FUTURE_DATE, 'Donations'),
     (testutil.FY_START_DATE, 'Donations'),
     (testutil.FY_MID_DATE, 'Donations'),
     (testutil.PAST_DATE, None),
 ])
 def test_default_value_set_in_date_range(hook, date, set_value):
     txn = testutil.Transaction(date=date, postings=[
         ('Assets:Cash', 25),

0 comments (0 inline, 0 general)