NPO-Accounting/conservancy_beancount Changeset - 90a58ef11258

Changeset - 90a58ef11258

Parent rev.

Child rev.

[Not reviewed]

0 2 0

Brett Smith - 4 years ago 2020-04-01 15:10:14
brettcsmith@brettcsmith.org

meta_project: Not required on Equity accounts.

2 files changed with 2 insertions and 1 deletions:

conservancy_beancount/plugin/meta_project.py

tests/test_meta_project.py

0 comments (0 inline, 0 general)

conservancy_beancount/plugin/meta_project.py

➞

Show inline comments

@@ ... / @@ -58,34 +58,34 @@ class MetaProject(core._NormalizePostingMetadataHook): @@
                 human_name = params.get('humanName', name)
                 if name != human_name:
                     aliases[human_name] = name
                 if name != key:
                     aliases[key] = name
         except AttributeError:
             self._config_error("loaded YAML data not in project-data format", project_data_path)
         except OSError as error:
             self._config_error(error.strerror, project_data_path)
         except yaml.error.YAMLError as error:
             self._config_error(error.args[0] or "YAML load error", project_data_path)
         else:
             self.VALUES_ENUM = core.MetadataEnum(self.METADATA_KEY, names, aliases)
     def _config_error(self, msg: str, filename: Optional[Path]=None) -> NoReturn:
         source = {}
         if filename is not None:
             source['filename'] = str(filename)
         raise errormod.ConfigurationError(
             "cannot load project data: " + msg,
             source=source,
+        )
     def _run_on_post(self, txn: Transaction, post: data.Posting) -> bool:
         return post.account.is_under('Assets', 'Liabilities') is None
+        return post.account.is_under('Assets', 'Equity', 'Liabilities') is None
     def _default_value(self, txn: Transaction, post: data.Posting) -> MetaValueEnum:
         if post.account.is_under(
                 'Accrued:VacationPayable',
                 'Expenses:Payroll',
         ):
             return self.DEFAULT_PROJECT
         else:
             raise errormod.InvalidMetadataError(txn, self.METADATA_KEY, None, post)

tests/test_meta_project.py

➞

Show inline comments

@@ ... / @@ -67,48 +67,49 @@ def test_invalid_values_on_postings(hook, src_value): @@
 @pytest.mark.parametrize('src_value,set_value', VALID_VALUES.items())
 def test_valid_values_on_transactions(hook, src_value, set_value):
     txn = testutil.Transaction(**{TEST_KEY: src_value}, postings=[
         ('Assets:Cash', -25),
         ('Expenses:General', 25),
     ])
     errors = list(hook.run(txn))
     assert not errors
     testutil.check_post_meta(txn, None, {TEST_KEY: set_value})
 @pytest.mark.parametrize('src_value', INVALID_VALUES)
 def test_invalid_values_on_transactions(hook, src_value):
     txn = testutil.Transaction(**{TEST_KEY: src_value}, postings=[
         ('Assets:Cash', -25),
         ('Expenses:General', 25),
     ])
     errors = list(hook.run(txn))
     assert errors
     testutil.check_post_meta(txn, None, None)
 @pytest.mark.parametrize('account,required', [
     ('Accrued:AccountsReceivable', True),
     ('Assets:Cash', False),
     ('Equity:Opening-Balances', False),
     ('Expenses:General', True),
     ('Income:Donations', True),
     ('Liabilities:CreditCard', False),
     ('UnearnedIncome:Donations', True),
 ])
 def test_which_accounts_required_on(hook, account, required):
     txn = testutil.Transaction(postings=[
         ('Assets:Checking', 25),
         (account, 25),
     ])
     errors = list(hook.run(txn))
     assert required == any(errors)
 @pytest.mark.parametrize('account', [
     'Accrued:VacationPayable',
     'Expenses:Payroll:Salary',
     'Expenses:Payroll:Tax',
 ])
 def test_default_values(hook, account):
     txn = testutil.Transaction(postings=[
         ('Assets:Checking', -25),
         (account, 25),
     ])
     errors = list(hook.run(txn))

0 comments (0 inline, 0 general)