NPO-Accounting/conservancy_beancount Changeset - 5f85d9c74776

Changeset - 5f85d9c74776

Parent rev.

Child rev.

[Not reviewed]

0 2 0

Brett Smith - 4 years ago 2020-03-29 14:21:37
brettcsmith@brettcsmith.org

config: Add Config.payment_threshold() method.

This just returns a constant for now, but we know it may need to be
configurable in the future. Other code can start using this now
to be configurable in the future.

2 files changed with 10 insertions and 0 deletions:

conservancy_beancount/config.py

tests/test_config.py

0 comments (0 inline, 0 general)

conservancy_beancount/config.py

➞

Show inline comments

@@ ... / @@ -5,24 +5,25 @@ @@
 # it under the terms of the GNU Affero General Public License as published by
 # the Free Software Foundation, either version 3 of the License, or
 # (at your option) any later version.
+#
 # This program is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU Affero General Public License for more details.
+#
 # You should have received a copy of the GNU Affero General Public License
 # along with this program.  If not, see <https://www.gnu.org/licenses/>.
 import decimal
 import functools
 import os
 import urllib.parse as urlparse
 import requests.auth
 import rt
 from pathlib import Path
 from typing import (
     NamedTuple,
     Optional,
     Type,
@@ ... / @@ -77,24 +78,27 @@ class Config: @@
             return path
     def cache_dir_path(self, name: str='conservancy_beancount') -> Optional[Path]:
         try:
             cache_root = Path(os.environ['XDG_CACHE_DIR'])
         except (KeyError, ValueError):
             cache_root = Path.home() / '.cache'
         return (
             self._dir_or_none(cache_root)
             and self._dir_or_none(cache_root / name)
+        )
     def payment_threshold(self) -> decimal.Decimal:
         return decimal.Decimal(0)
     def repository_path(self) -> Optional[Path]:
         try:
             return Path(os.environ['CONSERVANCY_REPOSITORY'])
         except (KeyError, ValueError):
             return None
     def rt_credentials(self) -> RTCredentials:
         all_creds = zip(
             RTCredentials.from_env(),
             RTCredentials.from_rtrc(),
             RTCredentials(auth='rt'),
+        )

tests/test_config.py

➞

Show inline comments

@@ ... / @@ -6,24 +6,25 @@ @@
 # the Free Software Foundation, either version 3 of the License, or
 # (at your option) any later version.
+#
 # This program is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU Affero General Public License for more details.
+#
 # You should have received a copy of the GNU Affero General Public License
 # along with this program.  If not, see <https://www.gnu.org/licenses/>.
 import contextlib
 import decimal
 import os
 import re
 import pytest
 from . import testutil
 from conservancy_beancount import config as config_mod
 RT_AUTH_METHODS = frozenset(['basic', 'gssapi', 'rt'])
 RT_ENV_KEYS = (
@@ ... / @@ -272,12 +273,17 @@ def test_cache_path_conflict(tmp_path): @@
     extant_path.touch()
     with update_environ(XDG_CACHE_DIR=tmp_path):
         config = config_mod.Config()
         cache_path = config.cache_dir_path(extant_path.name)
     assert cache_path is None
     assert extant_path.is_file()
 def test_cache_path_parent_conflict(tmp_path):
     (tmp_path / '.cache').touch()
     with update_environ(HOME=tmp_path, XDG_CACHE_DIR=None):
         config = config_mod.Config()
         assert config.cache_dir_path('TESTcache') is None
 def test_payment_threshold():
     threshold = config_mod.Config().payment_threshold()
     assert threshold == 0
     assert isinstance(threshold, (int, decimal.Decimal))

0 comments (0 inline, 0 general)