Changeset - 5140ca64f6d2
[Not reviewed]
0 1 1
Brett Smith - 4 years ago 2020-03-23 16:01:02
brettcsmith@brettcsmith.org
tests: Clean the environment before running tests.

As we start reading more sensitive user configuration (like RT credentials),
this fixture makes it simpler to ensure that the tests never read the user's
real configuration, which could lead to problems like passwords in tracebacks.
2 files changed with 9 insertions and 1 deletions:
0 comments (0 inline, 0 general)
tests/conftest.py
Show inline comments
 
new file 100644
 
import os
 

	
 
import pytest
 

	
 
from . import testutil
 

	
 
@pytest.fixture(scope='session', autouse=True)
 
def clean_environment():
 
    os.environ.pop('CONSERVANCY_REPOSITORY', None)
tests/test_config.py
Show inline comments
 
"""Test Config class"""
 
# Copyright © 2020  Brett Smith
 
#
 
# This program is free software: you can redistribute it and/or modify
 
# it under the terms of the GNU Affero General Public License as published by
 
# the Free Software Foundation, either version 3 of the License, or
 
# (at your option) any later version.
 
#
 
# This program is distributed in the hope that it will be useful,
 
# but WITHOUT ANY WARRANTY; without even the implied warranty of
 
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 
# GNU Affero General Public License for more details.
 
#
 
# You should have received a copy of the GNU Affero General Public License
 
# along with this program.  If not, see <https://www.gnu.org/licenses/>.
 

	
 
import contextlib
 
import os
 

	
 
from conservancy_beancount import config as config_mod
 

	
 
def _update_environ(updates):
 
    for key, value in updates.items():
 
        if value is None:
 
            os.environ.pop(key, None)
 
        else:
 
            os.environ[key] = str(value)
 

	
 
@contextlib.contextmanager
 
def update_environ(**kwargs):
 
    revert = {key: os.environ.get(key) for key in kwargs}
 
    _update_environ(kwargs)
 
    yield
 
    _update_environ(revert)
 

	
 
def test_repository_from_environment():
 
    with update_environ(CONSERVANCY_REPOSITORY='/usr/local'):
 
        config = config_mod.Config()
 
        assert config.repository_path().parts == ('/', 'usr', 'local')
 

	
 
def test_no_repository():
 
    with update_environ(CONSERVANCY_REPOSITORY=None):
 
    config = config_mod.Config()
 
    assert config.repository_path() is None
0 comments (0 inline, 0 general)