Changeset - 501bd251cbf3
Parent rev.
Child rev.
[Not reviewed]
0 3 0
Brett Smith - 4 years ago 2020-03-19 19:04:53
brettcsmith@brettcsmith.org
tests: Turn tested hooks into fixtures.

This is in preparation for passing configuration to hooks.
That'll be a big change already, so I wanted this to be a
boring diff first.
3 files changed with 58 insertions and 69 deletions:
tests/test_meta_expense_allocation.py
18
21
tests/test_meta_income_type.py
20
24
tests/test_meta_tax_implication.py
20
24
0 comments (0 inline, 0 general)
tests/test_meta_expense_allocation.py
➞
Show inline comments
...
 
@@ -38,45 +38,45 @@ INVALID_VALUES = {
 
TEST_KEY = 'expense-allocation'
 

			




	
	
	
		
 
@pytest.fixture(scope='module')


			




	
	
	
		
 
def hook():


			




	
	
	
		
 
    return meta_expense_allocation.MetaExpenseAllocation()


			




	
	
	
		
 

			




	
	
	
		
 
@pytest.mark.parametrize('src_value,set_value', VALID_VALUES.items())


			




	
	
	
		
 
def test_valid_values_on_postings(src_value, set_value):


			




	
	
	
		
 
def test_valid_values_on_postings(hook, src_value, set_value):


			




	
	
	
		
 
    txn = testutil.Transaction(postings=[


			




	
	
	
		
 
        ('Assets:Cash', -25),


			




	
	
	
		
 
        ('Expenses:General', 25, {TEST_KEY: src_value}),


			




	
	
	
		
 
    ])


			




	
	
	
		
 
    checker = meta_expense_allocation.MetaExpenseAllocation()


			




	
	
	
		
 
    errors = list(checker.run(txn))


			




	
	
	
		
 
    errors = list(hook.run(txn))


			




	
	
	
		
 
    assert not errors


			




	
	
	
		
 
    testutil.check_post_meta(txn, None, {TEST_KEY: set_value})


			




	
	
	
		
 

			




	
	
	
		
 
@pytest.mark.parametrize('src_value', INVALID_VALUES)


			




	
	
	
		
 
def test_invalid_values_on_postings(src_value):


			




	
	
	
		
 
def test_invalid_values_on_postings(hook, src_value):


			




	
	
	
		
 
    txn = testutil.Transaction(postings=[


			




	
	
	
		
 
        ('Assets:Cash', -25),


			




	
	
	
		
 
        ('Expenses:General', 25, {TEST_KEY: src_value}),


			




	
	
	
		
 
    ])


			




	
	
	
		
 
    checker = meta_expense_allocation.MetaExpenseAllocation()


			




	
	
	
		
 
    errors = list(checker.run(txn))


			




	
	
	
		
 
    errors = list(hook.run(txn))


			




	
	
	
		
 
    assert errors


			




	
	
	
		
 
    testutil.check_post_meta(txn, None, {TEST_KEY: src_value})


			




	
	
	
		
 

			




	
	
	
		
 
@pytest.mark.parametrize('src_value,set_value', VALID_VALUES.items())


			




	
	
	
		
 
def test_valid_values_on_transactions(src_value, set_value):


			




	
	
	
		
 
def test_valid_values_on_transactions(hook, src_value, set_value):


			




	
	
	
		
 
    txn = testutil.Transaction(**{TEST_KEY: src_value}, postings=[


			




	
	
	
		
 
        ('Assets:Cash', -25),


			




	
	
	
		
 
        ('Expenses:General', 25),


			




	
	
	
		
 
    ])


			




	
	
	
		
 
    checker = meta_expense_allocation.MetaExpenseAllocation()


			




	
	
	
		
 
    errors = list(checker.run(txn))


			




	
	
	
		
 
    errors = list(hook.run(txn))


			




	
	
	
		
 
    assert not errors


			




	
	
	
		
 
    testutil.check_post_meta(txn, None, {TEST_KEY: set_value})


			




	
	
	
		
 

			




	
	
	
		
 
@pytest.mark.parametrize('src_value', INVALID_VALUES)


			




	
	
	
		
 
def test_invalid_values_on_transactions(src_value):


			




	
	
	
		
 
def test_invalid_values_on_transactions(hook, src_value):


			




	
	
	
		
 
    txn = testutil.Transaction(**{TEST_KEY: src_value}, postings=[


			




	
	
	
		
 
        ('Assets:Cash', -25),


			




	
	
	
		
 
        ('Expenses:General', 25),


			




	
	
	
		
 
    ])


			




	
	
	
		
 
    checker = meta_expense_allocation.MetaExpenseAllocation()


			




	
	
	
		
 
    errors = list(checker.run(txn))


			




	
	
	
		
 
    errors = list(hook.run(txn))


			




	
	
	
		
 
    assert errors


			




	
	
	
		
 
    testutil.check_post_meta(txn, None, None)


			




	...
	
		
 
@@ -89,5 +89,5 @@ def test_invalid_values_on_transactions(src_value):


			




	
	
	
		
 
    'UnearnedIncome:Donations',


			




	
	
	
		
 
])


			




	
	
	
		
 
def test_non_expense_accounts_skipped(account):


			




	
	
	
		
 
def test_non_expense_accounts_skipped(hook, account):


			




	
	
	
		
 
    meta = {TEST_KEY: 'program'}


			




	
	
	
		
 
    txn = testutil.Transaction(postings=[


			




	...
	
		
 
@@ -95,6 +95,5 @@ def test_non_expense_accounts_skipped(account):


			




	
	
	
		
 
        ('Expenses:General', 25, meta.copy()),


			




	
	
	
		
 
    ])


			




	
	
	
		
 
    checker = meta_expense_allocation.MetaExpenseAllocation()


			




	
	
	
		
 
    errors = list(checker.run(txn))


			




	
	
	
		
 
    errors = list(hook.run(txn))


			




	
	
	
		
 
    assert not errors


			




	
	
	
		
 
    testutil.check_post_meta(txn, None, meta)


			




	...
	
		
 
@@ -107,11 +106,10 @@ def test_non_expense_accounts_skipped(account):


			




	
	
	
		
 
    ('Expenses:Services:Fundraising', 'fundraising'),


			




	
	
	
		
 
])


			




	
	
	
		
 
def test_default_values(account, set_value):


			




	
	
	
		
 
def test_default_values(hook, account, set_value):


			




	
	
	
		
 
    txn = testutil.Transaction(postings=[


			




	
	
	
		
 
        ('Liabilites:CreditCard', -25),


			




	
	
	
		
 
        (account, 25),


			




	
	
	
		
 
    ])


			




	
	
	
		
 
    checker = meta_expense_allocation.MetaExpenseAllocation()


			




	
	
	
		
 
    errors = list(checker.run(txn))


			




	
	
	
		
 
    errors = list(hook.run(txn))


			




	
	
	
		
 
    assert not errors


			




	
	
	
		
 
    testutil.check_post_meta(txn, None, {TEST_KEY: set_value})


			




	...
	
		
 
@@ -124,11 +122,10 @@ def test_default_values(account, set_value):


			




	
	
	
		
 
    (testutil.PAST_DATE, None),


			




	
	
	
		
 
])


			




	
	
	
		
 
def test_default_value_set_in_date_range(date, set_value):


			




	
	
	
		
 
def test_default_value_set_in_date_range(hook, date, set_value):


			




	
	
	
		
 
    txn = testutil.Transaction(date=date, postings=[


			




	
	
	
		
 
        ('Liabilites:CreditCard', -25),


			




	
	
	
		
 
        ('Expenses:General', 25),


			




	
	
	
		
 
    ])


			




	
	
	
		
 
    checker = meta_expense_allocation.MetaExpenseAllocation()


			




	
	
	
		
 
    errors = list(checker.run(txn))


			




	
	
	
		
 
    errors = list(hook.run(txn))


			




	
	
	
		
 
    assert not errors


			




	
	
	
		
 
    expect_meta = None if set_value is None else {TEST_KEY: set_value}


			




        

    


    
    

    

        

                

                    tests/test_meta_income_type.py
                

                

                  
                      
                        

                      ➞

                      
                        
                  

                  
                      
                  
                      
                  
                      
                  
                      
                  
                  
                

                

                    Show inline comments
                    
                

        

        

            



	...
	
		
 
@@ -38,45 +38,45 @@ INVALID_VALUES = {


			




	
	
	
		
 
TEST_KEY = 'income-type'


			




	
	
	
		
 

			




	
	
	
		
 
@pytest.fixture(scope='module')


			




	
	
	
		
 
def hook():


			




	
	
	
		
 
    return meta_income_type.MetaIncomeType()


			




	
	
	
		
 

			




	
	
	
		
 
@pytest.mark.parametrize('src_value,set_value', VALID_VALUES.items())


			




	
	
	
		
 
def test_valid_values_on_postings(src_value, set_value):


			




	
	
	
		
 
def test_valid_values_on_postings(hook, src_value, set_value):


			




	
	
	
		
 
    txn = testutil.Transaction(postings=[


			




	
	
	
		
 
        ('Assets:Cash', 25),


			




	
	
	
		
 
        ('Income:Other', -25, {TEST_KEY: src_value}),


			




	
	
	
		
 
    ])


			




	
	
	
		
 
    checker = meta_income_type.MetaIncomeType()


			




	
	
	
		
 
    errors = list(checker.run(txn))


			




	
	
	
		
 
    errors = list(hook.run(txn))


			




	
	
	
		
 
    assert not errors


			




	
	
	
		
 
    testutil.check_post_meta(txn, None, {TEST_KEY: set_value})


			




	
	
	
		
 

			




	
	
	
		
 
@pytest.mark.parametrize('src_value', INVALID_VALUES)


			




	
	
	
		
 
def test_invalid_values_on_postings(src_value):


			




	
	
	
		
 
def test_invalid_values_on_postings(hook, src_value):


			




	
	
	
		
 
    txn = testutil.Transaction(postings=[


			




	
	
	
		
 
        ('Assets:Cash', 25),


			




	
	
	
		
 
        ('Income:Other', -25, {TEST_KEY: src_value}),


			




	
	
	
		
 
    ])


			




	
	
	
		
 
    checker = meta_income_type.MetaIncomeType()


			




	
	
	
		
 
    errors = list(checker.run(txn))


			




	
	
	
		
 
    errors = list(hook.run(txn))


			




	
	
	
		
 
    assert errors


			




	
	
	
		
 
    testutil.check_post_meta(txn, None, {TEST_KEY: src_value})


			




	
	
	
		
 

			




	
	
	
		
 
@pytest.mark.parametrize('src_value,set_value', VALID_VALUES.items())


			




	
	
	
		
 
def test_valid_values_on_transactions(src_value, set_value):


			




	
	
	
		
 
def test_valid_values_on_transactions(hook, src_value, set_value):


			




	
	
	
		
 
    txn = testutil.Transaction(**{TEST_KEY: src_value}, postings=[


			




	
	
	
		
 
        ('Assets:Cash', 25),


			




	
	
	
		
 
        ('Income:Other', -25),


			




	
	
	
		
 
    ])


			




	
	
	
		
 
    checker = meta_income_type.MetaIncomeType()


			




	
	
	
		
 
    errors = list(checker.run(txn))


			




	
	
	
		
 
    errors = list(hook.run(txn))


			




	
	
	
		
 
    assert not errors


			




	
	
	
		
 
    testutil.check_post_meta(txn, None, {TEST_KEY: set_value})


			




	
	
	
		
 

			




	
	
	
		
 
@pytest.mark.parametrize('src_value', INVALID_VALUES)


			




	
	
	
		
 
def test_invalid_values_on_transactions(src_value):


			




	
	
	
		
 
def test_invalid_values_on_transactions(hook, src_value):


			




	
	
	
		
 
    txn = testutil.Transaction(**{TEST_KEY: src_value}, postings=[


			




	
	
	
		
 
        ('Assets:Cash', 25),


			




	
	
	
		
 
        ('Income:Other', -25),


			




	
	
	
		
 
    ])


			




	
	
	
		
 
    checker = meta_income_type.MetaIncomeType()


			




	
	
	
		
 
    errors = list(checker.run(txn))


			




	
	
	
		
 
    errors = list(hook.run(txn))


			




	
	
	
		
 
    assert errors


			




	
	
	
		
 
    testutil.check_post_meta(txn, None, None)


			




	...
	
		
 
@@ -88,5 +88,5 @@ def test_invalid_values_on_transactions(src_value):


			




	
	
	
		
 
    'Liabilities:CreditCard',


			




	
	
	
		
 
])


			




	
	
	
		
 
def test_non_income_accounts_skipped(account):


			




	
	
	
		
 
def test_non_income_accounts_skipped(hook, account):


			




	
	
	
		
 
    meta = {TEST_KEY: 'RBI'}


			




	
	
	
		
 
    txn = testutil.Transaction(postings=[


			




	...
	
		
 
@@ -94,6 +94,5 @@ def test_non_income_accounts_skipped(account):


			




	
	
	
		
 
        ('Income:Other', -25, meta.copy()),


			




	
	
	
		
 
    ])


			




	
	
	
		
 
    checker = meta_income_type.MetaIncomeType()


			




	
	
	
		
 
    errors = list(checker.run(txn))


			




	
	
	
		
 
    errors = list(hook.run(txn))


			




	
	
	
		
 
    assert not errors


			




	
	
	
		
 
    testutil.check_post_meta(txn, None, meta)


			




	...
	
		
 
@@ -111,11 +110,10 @@ def test_non_income_accounts_skipped(account):


			




	
	
	
		
 
    ('UnearnedIncome:MatchPledges', 'Donations'),


			




	
	
	
		
 
])


			




	
	
	
		
 
def test_default_values(account, set_value):


			




	
	
	
		
 
def test_default_values(hook, account, set_value):


			




	
	
	
		
 
    txn = testutil.Transaction(postings=[


			




	
	
	
		
 
        ('Assets:Cash', 25),


			




	
	
	
		
 
        (account, -25),


			




	
	
	
		
 
    ])


			




	
	
	
		
 
    checker = meta_income_type.MetaIncomeType()


			




	
	
	
		
 
    errors = list(checker.run(txn))


			




	
	
	
		
 
    errors = list(hook.run(txn))


			




	
	
	
		
 
    assert not errors


			




	
	
	
		
 
    testutil.check_post_meta(txn, None, {TEST_KEY: set_value})


			




	...
	
		
 
@@ -124,11 +122,10 @@ def test_default_values(account, set_value):


			




	
	
	
		
 
    'Income:Other',


			




	
	
	
		
 
])


			




	
	
	
		
 
def test_no_default_value(account):


			




	
	
	
		
 
def test_no_default_value(hook, account):


			




	
	
	
		
 
    txn = testutil.Transaction(postings=[


			




	
	
	
		
 
        ('Assets:Cash', 25),


			




	
	
	
		
 
        (account, -25),


			




	
	
	
		
 
    ])


			




	
	
	
		
 
    checker = meta_income_type.MetaIncomeType()


			




	
	
	
		
 
    errors = list(checker.run(txn))


			




	
	
	
		
 
    errors = list(hook.run(txn))


			




	
	
	
		
 
    assert errors


			




	
	
	
		
 
    testutil.check_post_meta(txn, None, None)


			




	...
	
		
 
@@ -141,11 +138,10 @@ def test_no_default_value(account):


			




	
	
	
		
 
    (testutil.PAST_DATE, None),


			




	
	
	
		
 
])


			




	
	
	
		
 
def test_default_value_set_in_date_range(date, set_value):


			




	
	
	
		
 
def test_default_value_set_in_date_range(hook, date, set_value):


			




	
	
	
		
 
    txn = testutil.Transaction(date=date, postings=[


			




	
	
	
		
 
        ('Assets:Cash', 25),


			




	
	
	
		
 
        ('Income:Donations', -25),


			




	
	
	
		
 
    ])


			




	
	
	
		
 
    checker = meta_income_type.MetaIncomeType()


			




	
	
	
		
 
    errors = list(checker.run(txn))


			




	
	
	
		
 
    errors = list(hook.run(txn))


			




	
	
	
		
 
    assert not errors


			




	
	
	
		
 
    expect_meta = None if set_value is None else {TEST_KEY: set_value}


			




        

    


    
    

    

        

                

                    tests/test_meta_tax_implication.py
                

                

                  
                      
                        

                      ➞

                      
                        
                  

                  
                      
                  
                      
                  
                      
                  
                      
                  
                  
                

                

                    Show inline comments
                    
                

        

        

            



	...
	
		
 
@@ -50,45 +50,45 @@ INVALID_VALUES = {


			




	
	
	
		
 
TEST_KEY = 'tax-implication'


			




	
	
	
		
 

			




	
	
	
		
 
@pytest.fixture(scope='module')


			




	
	
	
		
 
def hook():


			




	
	
	
		
 
    return meta_tax_implication.MetaTaxImplication()


			




	
	
	
		
 

			




	
	
	
		
 
@pytest.mark.parametrize('src_value,set_value', VALID_VALUES.items())


			




	
	
	
		
 
def test_valid_values_on_postings(src_value, set_value):


			




	
	
	
		
 
def test_valid_values_on_postings(hook, src_value, set_value):


			




	
	
	
		
 
    txn = testutil.Transaction(postings=[


			




	
	
	
		
 
        ('Accrued:AccountsPayable', 25),


			




	
	
	
		
 
        ('Assets:Cash', -25, {TEST_KEY: src_value}),


			




	
	
	
		
 
    ])


			




	
	
	
		
 
    checker = meta_tax_implication.MetaTaxImplication()


			




	
	
	
		
 
    errors = list(checker.run(txn))


			




	
	
	
		
 
    errors = list(hook.run(txn))


			




	
	
	
		
 
    assert not errors


			




	
	
	
		
 
    testutil.check_post_meta(txn, None, {TEST_KEY: set_value})


			




	
	
	
		
 

			




	
	
	
		
 
@pytest.mark.parametrize('src_value', INVALID_VALUES)


			




	
	
	
		
 
def test_invalid_values_on_postings(src_value):


			




	
	
	
		
 
def test_invalid_values_on_postings(hook, src_value):


			




	
	
	
		
 
    txn = testutil.Transaction(postings=[


			




	
	
	
		
 
        ('Accrued:AccountsPayable', 25),


			




	
	
	
		
 
        ('Assets:Cash', -25, {TEST_KEY: src_value}),


			




	
	
	
		
 
    ])


			




	
	
	
		
 
    checker = meta_tax_implication.MetaTaxImplication()


			




	
	
	
		
 
    errors = list(checker.run(txn))


			




	
	
	
		
 
    errors = list(hook.run(txn))


			




	
	
	
		
 
    assert errors


			




	
	
	
		
 
    testutil.check_post_meta(txn, None, {TEST_KEY: src_value})


			




	
	
	
		
 

			




	
	
	
		
 
@pytest.mark.parametrize('src_value,set_value', VALID_VALUES.items())


			




	
	
	
		
 
def test_valid_values_on_transactions(src_value, set_value):


			




	
	
	
		
 
def test_valid_values_on_transactions(hook, src_value, set_value):


			




	
	
	
		
 
    txn = testutil.Transaction(**{TEST_KEY: src_value}, postings=[


			




	
	
	
		
 
        ('Accrued:AccountsPayable', 25),


			




	
	
	
		
 
        ('Assets:Cash', -25),


			




	
	
	
		
 
    ])


			




	
	
	
		
 
    checker = meta_tax_implication.MetaTaxImplication()


			




	
	
	
		
 
    errors = list(checker.run(txn))


			




	
	
	
		
 
    errors = list(hook.run(txn))


			




	
	
	
		
 
    assert not errors


			




	
	
	
		
 
    testutil.check_post_meta(txn, None, {TEST_KEY: set_value})


			




	
	
	
		
 

			




	
	
	
		
 
@pytest.mark.parametrize('src_value', INVALID_VALUES)


			




	
	
	
		
 
def test_invalid_values_on_transactions(src_value):


			




	
	
	
		
 
def test_invalid_values_on_transactions(hook, src_value):


			




	
	
	
		
 
    txn = testutil.Transaction(**{TEST_KEY: src_value}, postings=[


			




	
	
	
		
 
        ('Accrued:AccountsPayable', 25),


			




	
	
	
		
 
        ('Assets:Cash', -25),


			




	
	
	
		
 
    ])


			




	
	
	
		
 
    checker = meta_tax_implication.MetaTaxImplication()


			




	
	
	
		
 
    errors = list(checker.run(txn))


			




	
	
	
		
 
    errors = list(hook.run(txn))


			




	
	
	
		
 
    assert errors


			




	
	
	
		
 
    testutil.check_post_meta(txn, None, None)


			




	...
	
		
 
@@ -99,5 +99,5 @@ def test_invalid_values_on_transactions(src_value):


			




	
	
	
		
 
    'Liabilities:CreditCard',


			




	
	
	
		
 
])


			




	
	
	
		
 
def test_non_asset_accounts_skipped(account):


			




	
	
	
		
 
def test_non_asset_accounts_skipped(hook, account):


			




	
	
	
		
 
    meta = {TEST_KEY: 'USA-Corporation'}


			




	
	
	
		
 
    txn = testutil.Transaction(postings=[


			




	...
	
		
 
@@ -105,26 +105,23 @@ def test_non_asset_accounts_skipped(account):


			




	
	
	
		
 
        ('Assets:Cash', -25, meta.copy()),


			




	
	
	
		
 
    ])


			




	
	
	
		
 
    checker = meta_tax_implication.MetaTaxImplication()


			




	
	
	
		
 
    errors = list(checker.run(txn))


			




	
	
	
		
 
    errors = list(hook.run(txn))


			




	
	
	
		
 
    assert not errors


			




	
	
	
		
 
    testutil.check_post_meta(txn, None, meta)


			




	
	
	
		
 

			




	
	
	
		
 
def test_prepaid_expenses_skipped():


			




	
	
	
		
 
def test_prepaid_expenses_skipped(hook, ):


			




	
	
	
		
 
    txn = testutil.Transaction(postings=[


			




	
	
	
		
 
        ('Expenses:General', 25),


			




	
	
	
		
 
        ('Assets:PrepaidExpenses', -25),


			




	
	
	
		
 
    ])


			




	
	
	
		
 
    checker = meta_tax_implication.MetaTaxImplication()


			




	
	
	
		
 
    errors = list(checker.run(txn))


			




	
	
	
		
 
    errors = list(hook.run(txn))


			




	
	
	
		
 
    assert not errors


			




	
	
	
		
 
    testutil.check_post_meta(txn, None, None)


			




	
	
	
		
 

			




	
	
	
		
 
def test_asset_credits_skipped():


			




	
	
	
		
 
def test_asset_credits_skipped(hook, ):


			




	
	
	
		
 
    txn = testutil.Transaction(postings=[


			




	
	
	
		
 
        ('Income:Donations', -25),


			




	
	
	
		
 
        ('Assets:Cash', 25),


			




	
	
	
		
 
    ])


			




	
	
	
		
 
    checker = meta_tax_implication.MetaTaxImplication()


			




	
	
	
		
 
    errors = list(checker.run(txn))


			




	
	
	
		
 
    errors = list(hook.run(txn))


			




	
	
	
		
 
    assert not errors


			




	
	
	
		
 
    testutil.check_post_meta(txn, None, None)


			




	...
	
		
 
@@ -137,11 +134,10 @@ def test_asset_credits_skipped():


			




	
	
	
		
 
    (testutil.PAST_DATE, False),


			




	
	
	
		
 
])


			




	
	
	
		
 
def test_validation_only_in_date_range(date, need_value):


			




	
	
	
		
 
def test_validation_only_in_date_range(hook, date, need_value):


			




	
	
	
		
 
    txn = testutil.Transaction(date=date, postings=[


			




	
	
	
		
 
        ('Liabilites:CreditCard', 25),


			




	
	
	
		
 
        ('Assets:Cash', -25),


			




	
	
	
		
 
    ])


			




	
	
	
		
 
    checker = meta_tax_implication.MetaTaxImplication()


			




	
	
	
		
 
    errors = list(checker.run(txn))


			




	
	
	
		
 
    errors = list(hook.run(txn))


			




	
	
	
		
 
    assert bool(errors) == bool(need_value)


			




	
	
	
		
 
    testutil.check_post_meta(txn, None, None)


			




        

    



    


    



    



      

      





    
    0 comments (0 inline, 0 general)
    





    


  

  







    


    

  


    








    
        Server instance: kapok.sfconservancy.org-5808
    
    
        This site is powered by
            Kallithea 0.6.3,
        which is
        © 2010–2020 by various authors & licensed under GPLv3.
            – Support
        – Privacy Policy