NPO-Accounting/conservancy_beancount Changeset - 4de5df9035f6

Changeset - 4de5df9035f6

Parent rev.

Child rev.

[Not reviewed]

0 2 0

Brett Smith - 3 years ago 2021-02-19 23:54:36
brettcsmith@brettcsmith.org

typing: Upgrade more Posting Iterables to Iterators.

2 files changed with 5 insertions and 4 deletions:

conservancy_beancount/cliutil.py

conservancy_beancount/filters.py

0 comments (0 inline, 0 general)

conservancy_beancount/cliutil.py

➞

Show inline comments

@@ ... / @@ -40,12 +40,13 @@ from typing import ( @@
     Callable,
     Container,
     Generic,
     Hashable,
     IO,
     Iterable,
     Iterator,
     NamedTuple,
     NoReturn,
     Optional,
     Sequence,
     TextIO,
     Type,
@@ ... / @@ -280,13 +281,13 @@ class SearchTerm(NamedTuple): @@
+                )
             if key is None:
                 raise ValueError(f"invalid search term {arg!r}: no metadata key")
             return cls(key, pattern)
         return parse_search_term
-    def filter_postings(self, postings: Iterable[data.Posting]) -> Iterable[data.Posting]:
+    def filter_postings(self, postings: Iterable[data.Posting]) -> Iterator[data.Posting]:
         return filters.filter_meta_match(
             postings, self.meta_key, re.compile(self.pattern),
+        )
 def add_jobs_argument(parser: argparse.ArgumentParser) -> argparse.Action:
     return parser.add_argument(

conservancy_beancount/filters.py

➞

Show inline comments

@@ ... @@
     for entry in entries:
         if (isinstance(entry, bc_data.Custom)
             and entry.type == 'conservancy_beancount_audit'):  # type:ignore[attr-defined]
             return entry.date
     return None
-def filter_meta_equal(postings: Postings, key: MetaKey, value: MetaValue) -> Postings:
+def filter_meta_equal(postings: Postings, key: MetaKey, value: MetaValue) -> Iterator[data.Posting]:
     for post in postings:
         try:
             if post.meta[key] == value:
                 yield post
         except KeyError:
             pass
-def filter_meta_match(postings: Postings, key: MetaKey, regexp: Regexp) -> Postings:
+def filter_meta_match(postings: Postings, key: MetaKey, regexp: Regexp) -> Iterator[data.Posting]:
     for post in postings:
         try:
             if re.search(regexp, post.meta[key]):
                 yield post
         except (KeyError, TypeError):
             pass
-def filter_for_rt_id(postings: Postings, ticket_id: Union[int, str]) -> Postings:
+def filter_for_rt_id(postings: Postings, ticket_id: Union[int, str]) -> Iterator[data.Posting]:
     """Filter postings with a primary RT ticket
     This functions yields postings where the *first* rt-id matches the given
     ticket number.
     """
     regexp = rtutil.RT.metadata_regexp(ticket_id, first_link_only=True)

0 comments (0 inline, 0 general)