NPO-Accounting/conservancy_beancount Changeset - 3a4c8526b2b2

Changeset - 3a4c8526b2b2

Parent rev.

Child rev.

[Not reviewed]

0 2 0

Brett Smith - 4 years ago 2020-03-31 19:04:15
brettcsmith@brettcsmith.org

meta_entity: Not required for Equity accounts.

2 files changed with 2 insertions and 1 deletions:

conservancy_beancount/plugin/meta_entity.py

tests/test_meta_entity.py

0 comments (0 inline, 0 general)

conservancy_beancount/plugin/meta_entity.py

➞

Show inline comments

@@ ... / @@ -30,21 +30,21 @@ class MetaEntity(core.TransactionHook): @@
     def run(self, txn: Transaction) -> errormod.Iter:
         txn_entity = txn.meta.get(self.METADATA_KEY)
         if txn_entity is None:
             txn_entity_ok = None
         elif isinstance(txn_entity, str):
             txn_entity_ok = bool(self.ENTITY_RE.match(txn_entity))
         else:
             txn_entity_ok = False
         if txn_entity_ok is False:
             yield errormod.InvalidMetadataError(txn, self.METADATA_KEY, txn_entity)
         for post in data.iter_postings(txn):
             if post.account.is_under('Assets', 'Liabilities'):
+            if post.account.is_under('Assets', 'Equity', 'Liabilities'):
                 continue
             entity = post.meta.get(self.METADATA_KEY)
             if entity is None:
                 yield errormod.InvalidMetadataError(txn, self.METADATA_KEY, entity, post)
             elif entity is txn_entity:
                 pass
             elif not self.ENTITY_RE.match(entity):
                 yield errormod.InvalidMetadataError(txn, self.METADATA_KEY, entity, post)

tests/test_meta_entity.py

➞

Show inline comments

@@ ... / @@ -75,24 +75,25 @@ def test_invalid_values_on_transactions(hook, src_value): @@
     txn = testutil.Transaction(**{TEST_KEY: src_value}, postings=[
         ('Assets:Cash', -25),
         ('Expenses:General', 25),
     ])
     errors = list(hook.run(txn))
     assert 1 <= len(errors) <= 2
     assert all(error.message == "transaction has invalid entity: {}".format(src_value)
                for error in hook.run(txn))
 @pytest.mark.parametrize('account,required', [
     ('Accrued:AccountsReceivable', True),
     ('Assets:Cash', False),
     ('Equity:OpeningBalances', False),
     ('Expenses:General', True),
     ('Income:Donations', True),
     ('Liabilities:CreditCard', False),
     ('UnearnedIncome:Donations', True),
 ])
 def test_which_accounts_required_on(hook, account, required):
     txn = testutil.Transaction(postings=[
         ('Assets:Checking', 25),
         (account, 25),
     ])
     errors = list(hook.run(txn))
     if not required:

0 comments (0 inline, 0 general)