NPO-Accounting/conservancy_beancount Changeset - 39fa977f71ce

Changeset - 39fa977f71ce

Parent rev.

Child rev.

[Not reviewed]

0 2 0

Brett Smith - 4 years ago 2020-06-04 14:49:55
brettcsmith@brettcsmith.org

reports: Balance.le/ge_zero returns False when exactly at tolerance.

2 files changed with 8 insertions and 2 deletions:

conservancy_beancount/reports/core.py

tests/test_reports_balance.py

0 comments (0 inline, 0 general)

conservancy_beancount/reports/core.py

➞

Show inline comments

@@ ... / @@ -169,3 +169,4 @@ class Balance(Mapping[str, data.Amount]): @@
         """Returns true if all amounts in the balance >= 0, within tolerance."""
         return self._all_amounts(operator.ge, -self.tolerance)
         op_func = operator.gt if self.tolerance else operator.ge
         return self._all_amounts(op_func, -self.tolerance)
@@ ... / @@ -173,3 +174,4 @@ class Balance(Mapping[str, data.Amount]): @@
         """Returns true if all amounts in the balance <= 0, within tolerance."""
         return self._all_amounts(operator.le, self.tolerance)
         op_func = operator.lt if self.tolerance else operator.le
         return self._all_amounts(op_func, self.tolerance)

tests/test_reports_balance.py

➞

Show inline comments

@@ ... / @@ -114,2 +114,4 @@ def test_eq_zero(mapping, expected): @@
     ({'EUR': '-0.00052'}, True),
     ({'RUB': core.Balance.TOLERANCE}, True),
     ({'RUB': -core.Balance.TOLERANCE}, False),
 ])
@@ ... / @@ -131,2 +133,4 @@ def test_ge_zero(mapping, expected): @@
     ({'EUR': '-0.00052'}, True),
     ({'RUB': core.Balance.TOLERANCE}, False),
     ({'RUB': -core.Balance.TOLERANCE}, True),
 ])

0 comments (0 inline, 0 general)