NPO-Accounting/conservancy_beancount Changeset - 391fde5447de

Changeset - 391fde5447de

Parent rev.

Child rev.

[Not reviewed]

0 2 0

Brett Smith - 3 years ago 2021-01-09 15:09:08
brettcsmith@brettcsmith.org

fields: TextField.set_value() accepts numeric types.

2 files changed with 28 insertions and 1 deletions:

conservancy_beancount/pdfforms/fields.py

tests/test_pdfforms_fields.py

0 comments (0 inline, 0 general)

conservancy_beancount/pdfforms/fields.py

➞

Show inline comments

@@ ... / @@ -8,6 +8,10 @@ @@
 import enum
 import functools
 from decimal import Decimal
 import babel.numbers  # type:ignore[import]
 from pdfminer.pdftypes import resolve1  # type:ignore[import]
 from pdfminer import psparser  # type:ignore[import]
 from . import utils as pdfutils
@@ ... / @@ -22,6 +26,7 @@ from typing import ( @@
     Sequence,
     Tuple,
     Union,
     cast,
+)
 FieldSource = MutableMapping[str, Any]
@@ ... / @@ -238,7 +243,9 @@ class TextField(FormField): @@
     def value(self) -> Optional[str]:
         return self._decode(super().value())
     def set_value(self, value: Optional[str]) -> None:
     def set_value(self, value: Union[str, Decimal, float, int, None]) -> None:
         if isinstance(value, (Decimal, float, int)):
             value = cast(str, babel.numbers.format_decimal(value))
         super().set_value(None if value is None else pdfutils.encode_text(value))
     def fill_value(self) -> Optional[str]:

tests/test_pdfforms_fields.py

➞

Show inline comments

@@ ... / @@ -10,6 +10,8 @@ import itertools @@
 import pytest
 from decimal import Decimal
 from pdfminer.psparser import PSLiteral
 from conservancy_beancount.pdfforms import fields as fieldsmod
@@ ... / @@ -249,6 +251,24 @@ def test_text_set_value(text, bprefix): @@
     actual = fieldsmod.FormField.value(field)
     assert actual == bprefix + text.encode('utf-16be' if bprefix else 'ascii')
 @pytest.mark.parametrize('expected', [
     '0',
     '32',
     '32.45',
     '32,768',
     '32,768.95',
 ])
 def test_text_set_value_numeric(expected):
     num_s = expected.replace(',', '')
     field = fieldsmod.TextField({})
     num_types = [Decimal, float]
     if '.' not in expected:
         num_types.append(int)
     for num_type in num_types:
         field.set_value(num_type(num_s))
         assert field.value() == expected
         field.set_value(None)
 def test_text_set_value_none():
     source = field_source('t', b'set None test', 'Tx')
     field = fieldsmod.TextField(source)

0 comments (0 inline, 0 general)