NPO-Accounting/conservancy_beancount Changeset - 2a33e178927b

Changeset - 2a33e178927b

Parent rev.

Child rev.

[Not reviewed]

0 1 0

Brett Smith - 4 years ago 2020-06-12 18:34:41
brettcsmith@brettcsmith.org

accrual: Clean up comments.

1 file changed with 1 insertions and 5 deletions:

conservancy_beancount/reports/accrual.py

0 comments (0 inline, 0 general)

conservancy_beancount/reports/accrual.py

➞

Show inline comments

@@ ... / @@ -175,14 +175,12 @@ class AccrualPostings(core.RelatedPostings): @@
     def __init__(self,
                  source: Iterable[data.Posting]=(),
                  *,
                  _can_own: bool=False,
     ) -> None:
         super().__init__(source, _can_own=_can_own)
         # The following type declarations tell mypy about values set in the for
         # loop that are important enough to be referenced directly elsewhere.
         self.account = self._single_item(post.account for post in self)
         if isinstance(self.account, Sentinel):
             self.accrual_type: Optional[AccrualAccount] = None
             norm_func: Callable[[T], T] = lambda x: x
             entity_pred: Callable[[data.Posting], bool] = bool
         else:
@@ ... / @@ -215,15 +213,13 @@ class AccrualPostings(core.RelatedPostings): @@
         entity_ok = isinstance(self.entity, str)
         # `'/' in self.invoice` is just our heuristic to ensure that the
         # invoice metadata is "unique enough," and not just a placeholder
         # value like "FIXME". It can be refined if needed.
         invoice_ok = isinstance(self.invoice, str) and '/' in self.invoice
         if account_ok and entity_ok and invoice_ok:
             # mypy loses track of the fact that self.invoice must be a str in
             # this case (gated on the invoice_ok boolean) and complains it
             # doesn't match the type of the return value.
             # type ignore for <https://github.com/python/mypy/issues/6670>
             yield (self.invoice, self)  # type:ignore[misc]
             return
         groups = collections.defaultdict(list)
         for post in self:
             post_invoice = self.invoice if invoice_ok else (
                 post.meta.get('invoice') or 'BlankInvoice'

0 comments (0 inline, 0 general)