NPO-Accounting/conservancy_beancount Changeset - 09b1548a963a

Changeset - 09b1548a963a

Parent rev.

Child rev.

[Not reviewed]

0 2 0

Brett Smith - 4 years ago 2020-06-27 21:36:02
brettcsmith@brettcsmith.org

reports: BaseODS.copy_element() recurses.

2 files changed with 31 insertions and 2 deletions:

conservancy_beancount/reports/core.py

tests/test_reports_spreadsheet.py

0 comments (0 inline, 0 general)

conservancy_beancount/reports/core.py

➞

Show inline comments

@@ ... / @@ -16,6 +16,7 @@ @@
 import abc
 import collections
 import copy
 import datetime
 import itertools
 import operator
@@ ... @@
     # methods to manipulate document settings or styles.
     def copy_element(self, elem: odf.element.Element) -> odf.element.Element:
         qattrs = dict(self.iter_qattributes(elem))
         retval = odf.element.Element(qname=elem.qname, qattributes=qattrs)
         retval = odf.element.Element(
             qname=elem.qname,
             qattributes=copy.copy(elem.attributes),
+        )
         try:
             orig_name = retval.getAttribute('name')
         except ValueError:
             orig_name = None
         if orig_name is not None:
             retval.setAttribute('name', f'{orig_name}{next(self._name_counter)}')
         for child in elem.childNodes:
             # Order is important: need to check the deepest subclasses first.
             if isinstance(child, odf.element.CDATASection):
                 retval.addCDATA(child.data)
             elif isinstance(child, odf.element.Text):
                 retval.addText(child.data)
             else:
                 retval.addElement(self.copy_element(child))
         return retval
     def ensure_child(self,

tests/test_reports_spreadsheet.py

➞

Show inline comments

@@ ... @@
     assert cell.getAttribute('valuetype') == 'string'
     assert cell.getAttribute('stylename') == style_name
     assert get_text(cell) == str(cell_source)
 def test_ods_writer_copy_element(ods_writer):
     child1 = odf.text.P()
     child1.addElement(odf.text.A(href='linkhref', text='linktext'))
     child2 = odf.text.P(text='para2')
     cell = odf.table.TableCell(stylename='cellsty')
     cell.addElement(child1)
     cell.addElement(child2)
     actual = ods_writer.copy_element(cell)
     assert actual is not cell
     assert actual.getAttribute('stylename') == 'cellsty'
     actual1, actual2 = actual.childNodes
     assert actual1 is not child1
     assert actual2 is not child2
     actual_a, = actual1.childNodes
     assert actual_a.getAttribute('href') == 'linkhref'
     assert actual_a.text == 'linktext'
     assert actual2.text == 'para2'

0 comments (0 inline, 0 general)