From d9dca2cd686b667bbf1bfd1708f5b6313d2d5ce7 2020-03-29 19:32:51
From: Brett Smith <brettcsmith@brettcsmith.org>
Date: 2020-03-29 19:32:51
Subject: [PATCH] data: Posting.is_payment casts threshold to address typing issue.

---

diff --git a/conservancy_beancount/data.py b/conservancy_beancount/data.py
index a6d8ae79dd7d2bc2bd2b9e0f79c3e5524ebeb62a..ddb319639a4b44c3c3067ad8a59d3c8510798ba4 100644
--- a/conservancy_beancount/data.py
+++ b/conservancy_beancount/data.py
@@ -25,6 +25,7 @@ import decimal
 from beancount.core import account as bc_account
 
 from typing import (
+    cast,
     Iterable,
     Iterator,
     MutableMapping,
@@ -212,13 +213,11 @@ class Posting(BasePosting):
     meta: Metadata  # type:ignore[assignment]
 
     def is_payment(self, threshold: DecimalCompat=0) -> bool:
+        threshold = cast(decimal.Decimal, threshold)
         return (
             self.account.is_real_asset()
             and self.units.number is not None
-            # mypy says abs returns an object and we can't negate that.
-            # Since we know threshold is numeric, it seems safe to assume
-            # the return value of abs is numeric as well.
-            and self.units.number < -abs(threshold)  # type:ignore[operator]
+            and self.units.number < -abs(threshold)
         )